From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WImwz-00084N-74 for qemu-devel@nongnu.org; Wed, 26 Feb 2014 17:27:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WImwq-0005SS-QN for qemu-devel@nongnu.org; Wed, 26 Feb 2014 17:27:37 -0500 Sender: Richard Henderson Message-ID: <530E6A33.8080607@twiddle.net> Date: Wed, 26 Feb 2014 14:26:59 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1392240199-2454-1-git-send-email-tommusta@gmail.com> <1392240199-2454-27-git-send-email-tommusta@gmail.com> <530B8883.5050908@twiddle.net> <530E3F09.8020904@gmail.com> <530E6554.60008@gmail.com> In-Reply-To: <530E6554.60008@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: Peter Maydell , qemu-ppc@nongnu.org On 02/26/2014 02:06 PM, Tom Musta wrote: > s/AES_Te4/AES_Te*/ > > And I should have added ... > > Even though I cannot use AES_Te4, I certainly can construct a flattened table > for InvMixColumns (a la AES_T*). This will result in a faster implementation. > > Does it make sense to put this InvMixColumns table in common utilities even > if PowerPC is the only user? It seems to be mainly an issue of space (about 4K). > Probably. I think that ideally we'd generate the tables from the sboxes at build time, rather than merely commenting them and pasting in the result. Ideally, we'd generate these tables into different source files, and thus into different object files, and thus the object file would only get pulled in when used. So ideally the issue of size would be a non-issue. r~