All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Philippe De Muyter <phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org>
Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] spi: spi-imx: spi_imx_remove: do not disable disabled clocks
Date: Thu, 27 Feb 2014 16:59:58 +0800	[thread overview]
Message-ID: <530EFE8E.5050303@freescale.com> (raw)
In-Reply-To: <1393491060-28074-1-git-send-email-phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org>

于 2014年02月27日 16:51, Philippe De Muyter 写道:
> -	clk_disable_unprepare(spi_imx->clk_ipg);
> -	clk_disable_unprepare(spi_imx->clk_per);
yes. we do not need to disable the clocks,
but we'd better to unprepare these two clocks.

thanks
Huang Shijie

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-02-27  8:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27  8:51 [PATCH] spi: spi-imx: spi_imx_remove: do not disable disabled clocks Philippe De Muyter
     [not found] ` <1393491060-28074-1-git-send-email-phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org>
2014-02-27  8:59   ` Huang Shijie [this message]
     [not found]     ` <530EFE8E.5050303-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-27  9:16       ` [PATCH v2] " Philippe De Muyter
     [not found]         ` <1393492575-32495-1-git-send-email-phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org>
2014-02-27  9:23           ` Huang Shijie
2014-02-28  3:46           ` Mark Brown
     [not found]             ` <20140228034620.GH9383-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-28  4:26               ` Huang Shijie
     [not found]                 ` <53100FEF.7060600-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-28  6:13                   ` Mark Brown
     [not found]                     ` <20140228061344.GD29849-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-28  6:28                       ` Huang Shijie
     [not found]                         ` <53102C74.2070609-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-01  4:09                           ` Mark Brown
2014-02-28  6:15           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530EFE8E.5050303@freescale.com \
    --to=b32955-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.