From: "Dmitry S. Dolzhenko" <dmitrys.dolzhenko@yandex.ru>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] branch: change install_branch_config() to use skip_prefix()
Date: Thu, 27 Feb 2014 17:05:48 +0400 [thread overview]
Message-ID: <530F382C.2030101@yandex.ru> (raw)
In-Reply-To: <530F248B.6030506@alum.mit.edu>
Michael,
Thank you for your remarks.
> If you look at what skip_prefix() and starts_with() do, I think you will
> find that you are doing too much work here.
How about this one?
const char *shortname = skip_prefix(remote, "refs/heads/");
int remote_is_branch = shortname != NULL;
prev parent reply other threads:[~2014-02-27 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 11:13 [PATCH] branch: change install_branch_config() to use skip_prefix() Dmitry S. Dolzhenko
2014-02-27 11:42 ` Michael Haggerty
2014-02-27 12:05 ` David Kastrup
2014-02-27 13:05 ` Dmitry S. Dolzhenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F382C.2030101@yandex.ru \
--to=dmitrys.dolzhenko@yandex.ru \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.