Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

On 02/27/2014 04:33 AM, Amit Shah wrote:
> On (Thu) 27 Feb 2014 [11:18:15], Stefan Hajnoczi wrote:
>> On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote:
>>> If TMPDIR is not specified, the default was to use /tmp for the working
>>> copy of the block devices.  Update this to /var/tmp instead, so systems
>>> using tmp-on-tmpfs don't end up inadvertently using RAM for the block
>>> device.
>>>
>>> Signed-off-by: Amit Shah <amit.shah@redhat.com>
>>> ---
>>>  block.c | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> Was expecting someone to argue against this because a path change is
>> always controversial :-).  But I think this makes sense and no one is
>> protesting....

No protests here.  Libvirt doesn't use -snapshot to trigger the behavior
in the first place, and even if it did, it is always possible to
explicitly set TMPDIR if you don't like the (changed) default.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]