From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1HK-0001S4-2v for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ1HD-0001zI-RQ for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:45:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1HD-0001zC-91 for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:45:27 -0500 Message-ID: <530F4172.3070500@redhat.com> Date: Thu, 27 Feb 2014 06:45:22 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393499376-4374-1-git-send-email-wenchaoqemu@gmail.com> <1393499376-4374-2-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1393499376-4374-2-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OJ2uhOGCMvih55ifQ9CxBcucHbpCQccvR" Subject: Re: [Qemu-devel] [PATCH V8 01/10] qapi script: remember explicitly defined enum values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OJ2uhOGCMvih55ifQ9CxBcucHbpCQccvR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia >=20 > Later other scripts will need to check the enum values. >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia Having two S-o-B by yourself looks awkward; is there one address we should be favoring? > --- > scripts/qapi.py | 16 +++++++++++----- > tests/qapi-schema/comments.out | 2 +- > tests/qapi-schema/qapi-schema-test.out | 10 +++++----- > 3 files changed, 17 insertions(+), 11 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OJ2uhOGCMvih55ifQ9CxBcucHbpCQccvR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD0FyAAoJEKeha0olJ0NqBRMH/iKwhU9gAA1YfLDN1T7sVeXO KZBcGBNeVy6jW+3is0KU+7kFkNDspML1tiyg6jN1LuhKLGEdkwAxGao9H5NDJ8hG Jn1UMmd7GMElqZzAwG2B1yo982FTGTwjO2BuwqQVkmeqbhX0ZKDqd/6MOiqfrQGa dibGVMzhKaReHNq+w4jZ1eTv7fjGgpO41T6yHqsircsgPYW/gZ0MdB/rNq8ObT5Q D1q5bLdAE33QMd+3NrmyxD7JbMysCc4wndJEgzL6FWv1H6eKGa/j1HQ5eOILxUhs ttLn3v6qtxB1HiByRHijZfbZRWPCeVk47ICqh3nsLedJ5dc9Cds7Hghf6z9IKes= =MpBu -----END PGP SIGNATURE----- --OJ2uhOGCMvih55ifQ9CxBcucHbpCQccvR--