From: Nishanth Menon <nm@ti.com>
To: Jingoo Han <jg1.han@samsung.com>,
"'Herbert Xu'" <herbert@gondor.apana.org.au>
Cc: "'David Miller'" <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>, "'Joel Fernandes'" <joelf@ti.com>
Subject: Re: [PATCH 1/3] crypto: omap-aes - Use SIMPLE_DEV_PM_OPS macro
Date: Thu, 27 Feb 2014 09:05:14 -0600 [thread overview]
Message-ID: <530F542A.8040606@ti.com> (raw)
In-Reply-To: <000301cf33af$7ad7cc50$708764f0$%han@samsung.com>
On 02/27/2014 05:31 AM, Jingoo Han wrote:
> Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/crypto/omap-aes.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> index dde41f1d..cb98fa5 100644
> --- a/drivers/crypto/omap-aes.c
> +++ b/drivers/crypto/omap-aes.c
> @@ -1307,9 +1307,7 @@ static int omap_aes_resume(struct device *dev)
> }
> #endif
>
> -static const struct dev_pm_ops omap_aes_pm_ops = {
> - SET_SYSTEM_SLEEP_PM_OPS(omap_aes_suspend, omap_aes_resume)
> -};
> +static SIMPLE_DEV_PM_OPS(omap_aes_pm_ops, omap_aes_suspend, omap_aes_resume);
>
> static struct platform_driver omap_aes_driver = {
> .probe = omap_aes_probe,
>
looks good to me,
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-02-27 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 11:31 [PATCH 1/3] crypto: omap-aes - Use SIMPLE_DEV_PM_OPS macro Jingoo Han
2014-02-27 11:32 ` [PATCH 2/3] crypto: omap-des " Jingoo Han
2014-02-27 11:33 ` [PATCH 3/3] crypto: omap-sham " Jingoo Han
2014-02-27 15:05 ` Nishanth Menon [this message]
2014-03-10 12:21 ` [PATCH 1/3] crypto: omap-aes " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F542A.8040606@ti.com \
--to=nm@ti.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jg1.han@samsung.com \
--cc=joelf@ti.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.