From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3ehsobe005.messaging.microsoft.com ([216.32.180.31]:19700 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbaB0QWj (ORCPT ); Thu, 27 Feb 2014 11:22:39 -0500 Message-ID: <530F6643.5090009@amd.com> Date: Thu, 27 Feb 2014 10:22:27 -0600 From: Aravind Gopalakrishnan MIME-Version: 1.0 To: Borislav Petkov CC: , , , , , , , , , , , Subject: Re: [PATCH] amd64_edac: Add support for newer F16h models References: <1392913726-16961-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20140221142749.GC11531@pd.tnic> <5307BF6F.8040303@amd.com> <20140224140931.GA16457@pd.tnic> In-Reply-To: <20140224140931.GA16457@pd.tnic> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 2/24/2014 8:09 AM, Borislav Petkov wrote: > On Fri, Feb 21, 2014 at 03:04:47PM -0600, Aravind Gopalakrishnan wrote: >> F{3,4} are used by hwmon/k10temp.c and hwmon/fam15h_power.c and they >> will need definitions to be places here in pci_ids.h But I'm not sure >> if the hwmon drivers need to carry support for this model yet (will >> verify that) >> >> If not, I'll remove them and resend. > Yes, please check that and let me know. > > Ok, here's more info: we will need to add support in k10temp for this model; and support is not required in fam15h_power as register bits used by the driver code are unavailable for OS. But F{3,4} usage is split: k10temp uses F3 device ID and fam15h_power uses F4 device ID. Not sure if you want to split these definitions between amd_nb.h and pci_ids.h or just let it be. Thanks, -Aravind.