All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs_io: add missing break in O_TMPFILE case
Date: Thu, 27 Feb 2014 14:16:49 -0600	[thread overview]
Message-ID: <530F9D31.5070103@redhat.com> (raw)

Coverity spotted this.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

(I assume that -T isn't supposed to imply -x?)

diff --git a/io/init.c b/io/init.c
index fd1a52f..1e2690e 100644
--- a/io/init.c
+++ b/io/init.c
@@ -181,6 +181,7 @@ init(
 			break;
 		case 'T':
 			flags |= IO_TMPFILE;
+			break;
 		case 'x':
 			expert = 1;
 			break;

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2014-02-27 20:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 20:16 Eric Sandeen [this message]
2014-02-27 20:21 ` [PATCH] xfs_io: add missing break in O_TMPFILE case Christoph Hellwig
2014-02-27 20:25 ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530F9D31.5070103@redhat.com \
    --to=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.