From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Jesse Gross <jesse@nicira.com>, <pshelar@nicira.com>,
<dev@openvswitch.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] openvswitch: Disable bottom half when grabbing stats lock in userspace context
Date: Thu, 27 Feb 2014 22:10:37 +0000 [thread overview]
Message-ID: <530FB7DD.6000500@citrix.com> (raw)
In-Reply-To: <1393538677-21268-1-git-send-email-zoltan.kiss@citrix.com>
On 27/02/14 22:04, Zoltan Kiss wrote:
> The megaflow feature introduced per-CPU stats, and the new code did some
> refactoring as well [1]. However the new functions doesn't disable bottom halves
> when locking the stat, and as they can be called from userspace context, they
> can be interrupted by netif_receive_skb.
Just forget about this, I'll send in soon the version with *_bh locks.
Zoli
WARNING: multiple messages have this Message-ID (diff)
From: Zoltan Kiss <zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
To: Jesse Gross <jesse-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>,
<pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>,
<dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] openvswitch: Disable bottom half when grabbing stats lock in userspace context
Date: Thu, 27 Feb 2014 22:10:37 +0000 [thread overview]
Message-ID: <530FB7DD.6000500@citrix.com> (raw)
In-Reply-To: <1393538677-21268-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
On 27/02/14 22:04, Zoltan Kiss wrote:
> The megaflow feature introduced per-CPU stats, and the new code did some
> refactoring as well [1]. However the new functions doesn't disable bottom halves
> when locking the stat, and as they can be called from userspace context, they
> can be interrupted by netif_receive_skb.
Just forget about this, I'll send in soon the version with *_bh locks.
Zoli
next prev parent reply other threads:[~2014-02-27 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 22:04 [PATCH] openvswitch: Disable bottom half when grabbing stats lock in userspace context Zoltan Kiss
2014-02-27 22:04 ` Zoltan Kiss
2014-02-27 22:10 ` Zoltan Kiss [this message]
2014-02-27 22:10 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530FB7DD.6000500@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=dev@openvswitch.org \
--cc=jesse@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.