From: Stephen Boyd <sboyd@codeaurora.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clk: shmobile: rcar-gen2: Use kick bit to allow Z clock frequency change
Date: Fri, 28 Feb 2014 00:03:19 +0000 [thread overview]
Message-ID: <530FD247.6030201@codeaurora.org> (raw)
In-Reply-To: <530C9D2A.8030409@baylibre.com>
On 02/27/14 14:46, Laurent Pinchart wrote:
> I'm not familiar with the hardware, but the patch below looks good to me.
> While you're at it, what would you think about replacing the
> __clk_is_enabled() call with a direct call to clk_is_enabled_regmap() ? Any
> user of __clk_is_enabled() outside the CCF core is suspect from a locking
> point of view, and exporting that function seems like a dangerous idea. On the
> other hand, if you had done so already I wouldn't have found the race
> condition.
Hm.. I guess that's ok. I like not having to care about what op is
assigned to the .is_enabled op though and we can't easily access the
.ops structure because it's hidden by the clk framework.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
prev parent reply other threads:[~2014-02-28 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 13:39 [PATCH] clk: shmobile: rcar-gen2: Use kick bit to allow Z clock frequency change Benoit Cousson
2014-02-25 15:59 ` Laurent Pinchart
2014-02-25 17:07 ` Benoit Cousson
2014-02-25 17:48 ` Laurent Pinchart
2014-02-26 20:54 ` Mike Turquette
2014-02-26 21:53 ` Laurent Pinchart
2014-02-27 0:50 ` Stephen Boyd
2014-02-27 22:46 ` Laurent Pinchart
2014-02-28 0:03 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530FD247.6030201@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.