From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WJGJt-0001aZ-27
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 00:49:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WJGJn-00054d-M3
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 00:49:12 -0500
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=42027
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WJGJn-00054X-FS
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 00:49:07 -0500
Message-ID: <5310234F.8040005@weilnetz.de>
Date: Fri, 28 Feb 2014 06:49:03 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1393539728-27389-1-git-send-email-pbonzini@redhat.com>
	<20140227225023.GF4165@localhost.localdomain>
	<53101E5A.3040903@weilnetz.de>
In-Reply-To: <53101E5A.3040903@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before
 recursing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

Am 28.02.2014 06:27, schrieb Stefan Weil:
> Am 27.02.2014 23:50, schrieb Jeff Cody:
>> On Thu, Feb 27, 2014 at 11:22:08PM +0100, Paolo Bonzini wrote:
>>> block-obj-y is not anymore part of common-obj-y, because "nesting"
>>> variables is complicated and requires specifying the correct
>>> ordering in the calls to unnest-vars.  However, because of this
>>> we need to specify block-obj-y in the dependencies of the
>>> target subdirectories.
>>>
>>> Thanks to Stefan Weil and Jeff Cody for suggesting the cause of
>>> the regression.
>>>
>>> Reported-by: Peter Maydell <peter.maydell@linaro.org>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>  Makefile | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index a443cd4..3938b6c 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -167,7 +167,7 @@ subdir-dtc:dtc/libfdt dtc/tests
>>>  dtc/%:
>>>  	mkdir -p $@
>>>  
>>> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
>>> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
> 
> Using SUBDIR_RULES here instead of SOFTMMU_SUBDIR_RULES (as in my patch)
> includes more dependencies: $(block-obj-y) will also be built for the
> user emulation code (i386-linux-user, ...) which does not need it. As
> far as I see, SOFTMMU_SUBDIR_RULES is sufficient.
> 
> Stefan

The additional dependencies break builds when system emulation and tools
are disabled (configure' '--enable-debug'
'--enable-trace-backend=stderr' '--disable-tools' --disable-docs
--disable-system):

make: Entering directory `/home/stefan/src/qemu'
  CC    async.o
  CC    qemu-timer.o
In file included from /home/stefan/src/qemu/include/ui/console.h:4:0,
                 from /home/stefan/src/qemu/qemu-timer.c:27:
/home/stefan/src/qemu/include/ui/qemu-pixman.h:14:20: fatal error:
pixman.h: No such file or directory
compilation terminated.
make: *** [qemu-timer.o] Error 1
make: Leaving directory `/home/stefan/src/qemu'