All of lore.kernel.org
 help / color / mirror / Atom feed
From: ZhangZhen <zhenzhang.zhang@huawei.com>
To: <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Subject: [PATCH] ext3: fix some wrong comments
Date: Fri, 28 Feb 2014 15:28:59 +0800	[thread overview]
Message-ID: <53103ABB.9030100@huawei.com> (raw)
In-Reply-To: <53100429.3000205@huawei.com>

The comments in the code are wrong, because every generic_file_write()
is replaced by generic_file_aio_write().

Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
---
 fs/ext3/inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 384b6eb..0b94832 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1574,7 +1574,7 @@ static int buffer_unmapped(handle_t *handle, struct buffer_head *bh)
  *
  * Similar for:
  *
- *	ext3_file_write() -> generic_file_write() -> __alloc_pages() -> ...
+ *	ext3_file_write() -> generic_file_aio_write() -> __alloc_pages() -> ...
  *
  * Same applies to ext3_get_block().  We will deadlock on various things like
  * lock_journal and i_truncate_mutex.
@@ -3212,7 +3212,7 @@ out_brelse:
  *
  * We are called from a few places:
  *
- * - Within generic_file_write() for O_SYNC files.
+ * - Within generic_file_aio_write() for O_SYNC files.
  *   Here, there will be no transaction running. We wait for any running
  *   transaction to commit.
  *
-- 
1.8.1.4


.




_______________________________________________
kernel.openeuler mailing list
kernel.openeuler@huawei.com
http://rnd-openeuler.huawei.com/mailman/listinfo/kernel.openeuler






       reply	other threads:[~2014-02-28  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <53100429.3000205@huawei.com>
2014-02-28  7:28 ` ZhangZhen [this message]
2014-02-28  8:37   ` [PATCH] ext3: fix some wrong comments Jan Kara
2014-03-03  1:44     ` ZhangZhen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53103ABB.9030100@huawei.com \
    --to=zhenzhang.zhang@huawei.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.