From: Lars-Peter Clausen <lars@metafoo.de>
To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
Cc: Mark Brown <broonie@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.
Date: Fri, 28 Feb 2014 09:15:37 +0100 [thread overview]
Message-ID: <531045A9.3010502@metafoo.de> (raw)
In-Reply-To: <049024c359df495fb8acedd96e574ce2@BY2PR03MB505.namprd03.prod.outlook.com>
On 02/28/2014 08:50 AM, Li.Xiubo@freescale.com wrote:
>
>>
>> A quick grep reveals:
>> mc13783.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL);
>> si476x.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL);
>> wm5102.c: codec->control_data = priv->core.arizona->regmap;
>> wm5110.c: codec->control_data = priv->core.arizona->regmap;
>> wm8997.c: codec->control_data = priv->core.arizona->regmap;
>>
>> But there might be more.
>>
>
> I have found the following ones, who are using MFD & set_cache_io.
>
> 1 143 sound/soc/codecs/cq93vc.c <<cq93vc_probe>>
> snd_soc_codec_set_cache_io(codec, 32, 32, SND_SOC_REGMAP);
> 2 618 sound/soc/codecs/mc13783.c <<mc13783_probe>>
> ret = snd_soc_codec_set_cache_io(codec, 8, 24, SND_SOC_REGMAP);
> 3 1765 sound/soc/codecs/wm5102.c <<wm5102_codec_probe>>
> ret = snd_soc_codec_set_cache_io(codec, 32, 16, SND_SOC_REGMAP);
> 4 1593 sound/soc/codecs/wm5110.c <<wm5110_codec_probe>>
> ret = snd_soc_codec_set_cache_io(codec, 32, 16, SND_SOC_REGMAP);
> 5 1510 sound/soc/codecs/wm8350.c <<wm8350_codec_probe>>
> snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP);
> 6 1322 sound/soc/codecs/wm8400.c <<wm8400_codec_probe>>
> snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP);
> 7 4004 sound/soc/codecs/wm8994.c <<wm8994_codec_probe>>
> snd_soc_codec_set_cache_io(codec, 16, 16, SND_SOC_REGMAP);
> 8 1058 sound/soc/codecs/wm8997.c <<wm8997_codec_probe>>
> ret = snd_soc_codec_set_cache_io(codec, 32, 16, SND_SOC_REGMAP);
Yes, I think that's almost all of them. si476x is missing, but I think that
one is currently broken, as it doesn't call snd_soc_codec_set_cache_io() at all.
As to how to handle those, I think there was a plan to add the possibility
to assign a regmap to a device, so that dev_get_regmap() returns the regmap
struct that should be used, even though the device itself did not allocate
the regmap. But I can't find the details. Mark may know more about this.
- Lars
next prev parent reply other threads:[~2014-02-28 8:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 9:49 [PATCH 0/3] To simplify the code for ASoC probe Xiubo Li
2014-02-27 9:49 ` Xiubo Li
2014-02-27 9:49 ` [PATCH 1/3] ASoC: io: Clean up snd_soc_codec_set_cache_io() Xiubo Li
2014-02-27 9:49 ` Xiubo Li
2014-02-28 3:47 ` Mark Brown
2014-02-27 9:49 ` [PATCH 2/3] ASoC: core: Set the default I/O up try regmap Xiubo Li
2014-02-27 9:49 ` Xiubo Li
2014-02-28 3:52 ` Mark Brown
2014-02-28 4:00 ` Li.Xiubo
2014-02-28 5:29 ` Mark Brown
2014-02-28 5:29 ` Mark Brown
2014-02-28 5:56 ` Li.Xiubo
2014-02-28 6:38 ` [alsa-devel] " Lars-Peter Clausen
2014-02-28 6:40 ` Li.Xiubo
2014-02-28 6:46 ` Lars-Peter Clausen
2014-02-28 7:08 ` Li.Xiubo
2014-02-28 7:15 ` Lars-Peter Clausen
2014-02-28 7:18 ` Li.Xiubo
2014-02-28 7:50 ` Li.Xiubo
2014-02-28 8:15 ` Lars-Peter Clausen [this message]
2014-03-01 4:07 ` Mark Brown
2014-02-27 9:49 ` [PATCH 3/3] ASoC: SGTL5000: Simplify ASoC probe code Xiubo Li
2014-02-27 9:49 ` Xiubo Li
2014-02-28 3:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531045A9.3010502@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.