All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Juan Quintela <quintela@redhat.com>, "pl@kamp.de" <pl@kamp.de>,
	"owasserm@redhat.com" <owasserm@redhat.com>,
	"aliguori@amazon.com" <aliguori@amazon.com>,
	"chenliang (T)" <chenliang88@huawei.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap
Date: Fri, 28 Feb 2014 06:11:20 -0700	[thread overview]
Message-ID: <53108AF8.8020602@redhat.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815D2278@SZXEMA503-MBS.china.huawei.com>

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On 02/27/2014 09:08 PM, Gonglei (Arei) wrote:
> Add counters to log the times of updating the dirty bitmap.
> 
> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  arch_init.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)

Is it also worth updating MigrationStats in qapi-schema.json to expose
these counts to the end user, to help benchmarking decide how often your
optimizations hit for a given workload?


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2014-02-28 13:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  4:08 [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap Gonglei (Arei)
2014-02-28  9:37 ` Dr. David Alan Gilbert
2014-02-28 13:11 ` Eric Blake [this message]
2014-02-28 13:26   ` 陈梁
2014-03-05 16:18 ` Juan Quintela
2014-03-06 10:50   ` Gonglei
2014-03-06 13:19     ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53108AF8.8020602@redhat.com \
    --to=eblake@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=arei.gonglei@huawei.com \
    --cc=chenliang88@huawei.com \
    --cc=owasserm@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.