From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52064)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJQKM-0003Y7-Pi
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:30:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJQKF-0003WT-Gb
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:30:22 -0500
Received: from cantor2.suse.de ([195.135.220.15]:56259 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJQKF-0003WH-AO
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:30:15 -0500
Message-ID: <5310B993.6080809@suse.de>
Date: Fri, 28 Feb 2014 17:30:11 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1393435114-26374-1-git-send-email-jjherne@us.ibm.com>
	<1393435114-26374-3-git-send-email-jjherne@us.ibm.com>
In-Reply-To: <1393435114-26374-3-git-send-email-jjherne@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Jason J. Herne" <jjherne@us.ibm.com>, borntraeger@de.ibm.com
Cc: agraf@suse.de, qemu-devel@nongnu.org

Am 26.02.2014 18:18, schrieb Jason J. Herne:
> From: "Jason J. Herne" <jjherne@us.ibm.com>
>=20
> Modify s390_cpu_addr2state to allow fetching state information for cpu =
addresses
> above smp_cpus.  Hotplug requires this capability.
>=20
> Also add s390_cpu_set_state function to allow modification of ipi_state=
 entries
> during hotplug.
>=20
> Signed-off-by: Jason J. Herne <jjherne@us.ibm.com>

This patch is *still* present despite your previous response that you
incorporated my review comments. You are adding a custom s390x API here
rather than reusing the generic QOM API as requested. I don't even read
further in such cases - like I pointed out, a pure resend is not helping
address review feedback!

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg