From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJQci-00022n-5z
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:49:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJQcb-000191-8j
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:49:20 -0500
Received: from cantor2.suse.de ([195.135.220.15]:56678 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJQcb-00018l-1g
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:49:13 -0500
Message-ID: <5310BE05.2060002@suse.de>
Date: Fri, 28 Feb 2014 17:49:09 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1393600696-24118-1-git-send-email-stefanha@redhat.com>
	<1393600696-24118-6-git-send-email-stefanha@redhat.com>
In-Reply-To: <1393600696-24118-6-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle
 temporary strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>

Am 28.02.2014 16:18, schrieb Stefan Hajnoczi:
> From: Igor Mammedov <imammedo@redhat.com>
>=20
> get_pointer()'s print() callback might return a heap allocated
> string, to avoid adding dedicated get_pointer_foo for this case
> convert current print() callbacks to return temporary heap
> allocated string and make get_pointer() free it.
>=20
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/core/qdev-properties-system.c | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)

Not aware of the history of this patch (not CC'ed?) but looks okay,

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Do we have any users outside of this series?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg