From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/ACPI: also print address space for PM1x fields
Date: Fri, 28 Feb 2014 16:55:43 +0000 [thread overview]
Message-ID: <5310BF8F.6080706@gmail.com> (raw)
In-Reply-To: <5310CC730200007800120495@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1368 bytes --]
Jan Beulich wrote:
>
> At least one vendor is in the process of making systems available where
> these live in MMIO, not in I/O port space.
>
> Signed-off-by: Jan Beulich<jbeulich@suse.com>
Probably an abundance of caution to keep everything platform related in
sync between dom0 and Xen. I agree this shouldn't be necessary in this
case and I'm okay with this simplification. Frankly I doubt anyone has
to specify this option on any halfway sane box anyway.
Acked-by: Keir Fraser <keir@xen.org>
>
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
> @@ -402,11 +402,15 @@ acpi_fadt_parse_sleep_info(struct acpi_t
> acpi_fadt_copy_address(pm1b_evt, pm1b_event, pm1_event);
>
> printk(KERN_INFO PREFIX
> - "SLEEP INFO: pm1x_cnt[%"PRIx64",%"PRIx64"], "
> - "pm1x_evt[%"PRIx64",%"PRIx64"]\n",
> + "SLEEP INFO: pm1x_cnt[%d:%"PRIx64",%d:%"PRIx64"], "
> + "pm1x_evt[%d:%"PRIx64",%d:%"PRIx64"]\n",
> + acpi_sinfo.pm1a_cnt_blk.space_id,
> acpi_sinfo.pm1a_cnt_blk.address,
> + acpi_sinfo.pm1b_cnt_blk.space_id,
> acpi_sinfo.pm1b_cnt_blk.address,
> + acpi_sinfo.pm1a_evt_blk.space_id,
> acpi_sinfo.pm1a_evt_blk.address,
> + acpi_sinfo.pm1b_evt_blk.space_id,
> acpi_sinfo.pm1b_evt_blk.address);
>
> /* Now FACS... */
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2142 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-02-28 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:50 [PATCH] x86/ACPI: also print address space for PM1x fields Jan Beulich
2014-02-28 16:55 ` Keir Fraser
2014-02-28 16:55 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310BF8F.6080706@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.