From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 09/10] ARM: tegra: Rename as3722 node to pmic
Date: Fri, 28 Feb 2014 10:20:58 -0700 [thread overview]
Message-ID: <5310C57A.6050200@wwwdotorg.org> (raw)
In-Reply-To: <1393605629-30514-9-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 02/28/2014 09:40 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Device tree node name should reflect the kind of device rather than the
> specific name of the device.
> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
> - as3722: as3722@40 {
> + pmic: pmic@40 {
The patch is fine, so I'll apply it, but note that the naming rule
applies to the node name only, since that's visible in the compiled DTB,
but not the label name, so this could have been left as:
as3722: pmic@40
That would have avoided the rest of the diffs in this patch, and might
have been useful on a board with a bunch of different PMICs that need to
be differentiated between.
next prev parent reply other threads:[~2014-02-28 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:40 [PATCH v3 01/10] ARM: tegra: Overhaul Venice2 regulators Thierry Reding
[not found] ` <1393605629-30514-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-28 16:40 ` [PATCH v3 02/10] ARM: tegra: Hook up SDMMC3 power-supply on Venice2 Thierry Reding
2014-02-28 16:40 ` [PATCH v3 03/10] ARM: tegra: Add Tegra124 host1x support Thierry Reding
2014-02-28 16:40 ` [PATCH v3 04/10] ARM: tegra: Add Tegra124 eDP support Thierry Reding
2014-02-28 16:40 ` [PATCH v3 05/10] ARM: tegra: Enable eDP for Venice2 Thierry Reding
2014-02-28 16:40 ` [PATCH v3 06/10] ARM: tegra: Add Tegra124 USB support Thierry Reding
2014-02-28 16:40 ` [PATCH v3 07/10] ARM: tegra: Enable USB on Venice2 Thierry Reding
2014-02-28 16:40 ` [PATCH v3 08/10] ARM: tegra: Fix whitespace around '=' Thierry Reding
2014-02-28 16:40 ` [PATCH v3 09/10] ARM: tegra: Rename as3722 node to pmic Thierry Reding
[not found] ` <1393605629-30514-9-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-28 17:20 ` Stephen Warren [this message]
2014-02-28 16:40 ` [PATCH v3 10/10] ARM: tegra: Update default configuration Thierry Reding
2014-02-28 17:42 ` [PATCH v3 01/10] ARM: tegra: Overhaul Venice2 regulators Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310C57A.6050200@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.