From: Eric Sandeen <sandeen@sandeen.net>
To: Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 5/8] xfstests: Add fallocate zero range operation to fsstress
Date: Fri, 28 Feb 2014 11:40:08 -0600 [thread overview]
Message-ID: <5310C9F8.20009@sandeen.net> (raw)
In-Reply-To: <1393603865-26198-5-git-send-email-lczerner@redhat.com>
On 2/28/14, 10:11 AM, Lukas Czerner wrote:
> This commit adds fzero operation support for fsstress, which is meant to
> exercise fallocate FALLOC_FL_ZERO_RANGE support.
>
> Also reorganise the common fallocate code into a single do_fallocate()
> function and use flags use the right mode.
>
> Also in order to make more obvious which fallocate mode fsstress is
> testing translate fallocate flags into human readable strings.
Can you enhance that so that if it's passed a flag which isn't
in the known array, it prints the leftover values? Otherwise
they are silently dropped, which might be confusing.
Handling the case where a flag is not in the array would future-proof
it, I think.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-28 17:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:10 [PATCH 1/8] xfstests: Create single function for testing xfs_io commands Lukas Czerner
2014-02-28 16:10 ` Lukas Czerner
2014-02-28 16:10 ` [PATCH 2/8] xfstests: create _test_block_boundaries in common/punch Lukas Czerner
2014-02-28 16:10 ` Lukas Czerner
2014-02-28 16:11 ` [PATCH 3/8] generic/008: Add test for fallocate zero range at block boundary Lukas Czerner
2014-02-28 16:11 ` Lukas Czerner
2014-02-28 16:11 ` [PATCH 4/8] xfstests: Move fallocate include into global.h Lukas Czerner
2014-02-28 16:11 ` Lukas Czerner
2014-02-28 17:17 ` Eric Sandeen
2014-02-28 17:17 ` Eric Sandeen
2014-02-28 22:31 ` Dave Chinner
2014-02-28 22:31 ` Dave Chinner
2014-02-28 16:11 ` [PATCH 5/8] xfstests: Add fallocate zero range operation to fsstress Lukas Czerner
2014-02-28 16:11 ` Lukas Czerner
2014-02-28 17:40 ` Eric Sandeen [this message]
2014-03-03 12:16 ` Lukáš Czerner
2014-03-03 12:16 ` Lukáš Czerner
2014-02-28 16:11 ` [PATCH 6/8] fsstress: translate flags in fiemap_f Lukas Czerner
2014-02-28 16:11 ` Lukas Czerner
2014-02-28 17:55 ` Eric Sandeen
2014-02-28 16:11 ` [PATCH 7/8] xfstests: Add fallocate zero range operation to fsx Lukas Czerner
2014-02-28 16:11 ` Lukas Czerner
2014-02-28 18:11 ` Eric Sandeen
2014-02-28 18:11 ` Eric Sandeen
2014-02-28 19:08 ` Andreas Dilger
2014-03-03 12:21 ` Lukáš Czerner
2014-02-28 16:11 ` [PATCH 8/8] ext4/001: Add ext4 specific test for fallocate zero range Lukas Czerner
2014-02-28 16:11 ` Lukas Czerner
2014-02-28 16:40 ` [PATCH 1/8] xfstests: Create single function for testing xfs_io commands Eric Sandeen
2014-02-28 16:51 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310C9F8.20009@sandeen.net \
--to=sandeen@sandeen.net \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.