From: Ben Greear <greearb@candelatech.com>
To: bartosz.markowski@tieto.com
Cc: Marek Kwaczynski <marek.kwaczynski@tieto.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: add recalc RTS/CTS protection method
Date: Fri, 28 Feb 2014 09:46:29 -0800 [thread overview]
Message-ID: <5310CB75.9030706@candelatech.com> (raw)
In-Reply-To: <1393571908-23734-1-git-send-email-marek.kwaczynski@tieto.com>
On 02/27/2014 11:18 PM, bartosz.markowski@tieto.com wrote:
> From: Marek Kwaczynski <marek.kwaczynski@tieto.com>
>
> Add recalculation of RTS/CTS protection when one or more legacy
> stations are connected to ath10k. In this case enable RTS/CTS
> protection and set sw retry profile are needed in the FW.
> Without this change legacy station is starved and has very low
> throughput.
> - ath10k_warn("Failed to set CTS prot for VDEV: %d\n",
> - arvif->vdev_id);
> + ath10k_warn("failed to recalc RTS/CTS prot %d\n",
> + ret);
Did you remove the vdev ID from the logging message on purpose?
I find having vdev ID in logging messages helps, especially when
trying to compare firmware logs with the driver logs...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: bartosz.markowski@tieto.com
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Marek Kwaczynski <marek.kwaczynski@tieto.com>
Subject: Re: [PATCH] ath10k: add recalc RTS/CTS protection method
Date: Fri, 28 Feb 2014 09:46:29 -0800 [thread overview]
Message-ID: <5310CB75.9030706@candelatech.com> (raw)
In-Reply-To: <1393571908-23734-1-git-send-email-marek.kwaczynski@tieto.com>
On 02/27/2014 11:18 PM, bartosz.markowski@tieto.com wrote:
> From: Marek Kwaczynski <marek.kwaczynski@tieto.com>
>
> Add recalculation of RTS/CTS protection when one or more legacy
> stations are connected to ath10k. In this case enable RTS/CTS
> protection and set sw retry profile are needed in the FW.
> Without this change legacy station is starved and has very low
> throughput.
> - ath10k_warn("Failed to set CTS prot for VDEV: %d\n",
> - arvif->vdev_id);
> + ath10k_warn("failed to recalc RTS/CTS prot %d\n",
> + ret);
Did you remove the vdev ID from the logging message on purpose?
I find having vdev ID in logging messages helps, especially when
trying to compare firmware logs with the driver logs...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-02-28 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 7:18 [PATCH] ath10k: add recalc RTS/CTS protection method bartosz.markowski
2014-02-28 7:18 ` bartosz.markowski
2014-02-28 17:46 ` Ben Greear [this message]
2014-02-28 17:46 ` Ben Greear
2014-03-03 7:35 ` Bartosz Markowski
2014-03-03 7:35 ` Bartosz Markowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310CB75.9030706@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.kwaczynski@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.