From: Phillip Susi <psusi@ubuntu.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: "Maciej Małecki" <me@mmalecki.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] fdisk: warn if opening a device in write mode failed
Date: Fri, 28 Feb 2014 14:18:24 -0500 [thread overview]
Message-ID: <5310E100.5020405@ubuntu.com> (raw)
In-Reply-To: <1393612047.2899.31.camel@buesod1.americas.hpqcorp.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2/28/2014 1:27 PM, Davidlohr Bueso wrote:
>> You really want to tell the user that they aren't going to be
>> able to write up front.
>
> Sure why not, just not in a library! You can do this in the fdisk
> program. And if Karel doesn't agree and wants to apply this patch
> anyway, then it should *at least* be in DBG context.
Right, which is what I said just after that ;)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTEOEAAAoJEI5FoCIzSKrwgosH/2VJe8a639As2jvFhBDnp8Fr
H0xuH1fPt/RTE3+d9GlCHlBsfWQlmBgNEzItJR2hCnHLikf8ghY8SXwCXqgmUYZa
RGdwyU10ulhBC552F5x2I+Qgu7xGRxsOhHOlxpgzrPtsZNkf5vqXwlNjxjGr2i2G
zLcdH4Oq2K/D0JoPEKS5Bn8xnbNL/vnd7B6Hn9tqZ8+RfPm6iajr5bIPGOpLOa2E
S/FBo+8Abjln2DIllSZGwQLsoidyWv3fT2iGxaMmtkAGNn9Dbw/r7Uvq4Yt1OICB
/T7F3y1fYb+E/1JPaNneM0wl2smyl3em40uKBuGIi4rhj0g2QVycmANOmol1P0U=
=rQOh
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-02-28 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 3:26 [PATCH 1/2] fdisk: warn if opening a device in write mode failed Maciej Małecki
2014-02-27 3:26 ` [PATCH 2/2] fdisk: do not allow writing to a read-only device Maciej Małecki
2014-02-28 2:32 ` [PATCH 1/2] fdisk: warn if opening a device in write mode failed Davidlohr Bueso
2014-02-28 11:00 ` Maciej Małecki
2014-02-28 16:23 ` Phillip Susi
2014-02-28 18:18 ` Maciej Małecki
2014-02-28 18:27 ` Davidlohr Bueso
2014-02-28 19:18 ` Phillip Susi [this message]
2014-03-03 9:04 ` Karel Zak
2014-03-03 21:19 ` Maciej Małecki
2014-03-03 21:47 ` Phillip Susi
2014-03-21 13:10 ` Karel Zak
2014-03-03 21:14 ` [PATCH v2 1/3] fdisk: do not allow writing to a read-only device Maciej Małecki
2014-03-03 21:14 ` [PATCH v2 2/3] libfdisk: remove `O_RDONLY` fallback mode when opening device Maciej Małecki
2014-03-03 21:14 ` [PATCH v2 3/3] fdisk: retry opening device in read-only mode Maciej Małecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310E100.5020405@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=davidlohr@hp.com \
--cc=me@mmalecki.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.