From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
c_manoha@qca.qualcomm.com
Subject: Re: [PATCH 1/2] ath9k_hw: toggle weak signal detection in AP mode on older chipsets
Date: Fri, 28 Feb 2014 21:52:30 +0100 [thread overview]
Message-ID: <5310F70E.5030501@openwrt.org> (raw)
In-Reply-To: <21264.55526.187330.480735@gargle.gargle.HOWL>
On 2014-02-28 19:43, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> - if (ah->opmode != NL80211_IFTYPE_AP &&
>> - aniState->ofdmWeakSigDetect != weak_sig) {
>> - ath9k_hw_ani_control(ah,
>> - ATH9K_ANI_OFDM_WEAK_SIGNAL_DETECTION,
>> - entry_ofdm->ofdm_weak_signal_on);
>> - }
>> + else if (AR_SREV_9300_20_OR_LATER(ah) &&
>> + ah->opmode != NL80211_IFTYPE_STATION)
>> + weak_sig = true;
>> +
>> + if (aniState->ofdmWeakSigDetect != weak_sig)
>> + ath9k_hw_ani_control(ah, ATH9K_ANI_OFDM_WEAK_SIGNAL_DETECTION,
>> + weak_sig);
>
> Any reason why this has been changed to disregard the WS-DET parameter from
> ofdm_level_table[] ?
It doesn't disregard it - weak_sig is initialized to the value of that
parameter. Comparing aniState->ofdmWeakSigDetect against weak_sig, but
then passing entry_ofdm->ofdm_weak_signal_on is buggy.
- Felix
prev parent reply other threads:[~2014-02-28 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 18:02 [PATCH 1/2] ath9k_hw: toggle weak signal detection in AP mode on older chipsets Felix Fietkau
2014-02-28 18:02 ` [PATCH 2/2] ath9k_hw: tweak noise immunity thresholds for " Felix Fietkau
2014-02-28 18:52 ` Sujith Manoharan
2014-02-28 20:54 ` Felix Fietkau
2014-02-28 18:43 ` [PATCH 1/2] ath9k_hw: toggle weak signal detection in AP mode on " Sujith Manoharan
2014-02-28 20:52 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310F70E.5030501@openwrt.org \
--to=nbd@openwrt.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.