Re: [PATCH 1/3] staging/usbip: add uapi header to export usbip kernel interfaces

[Shuah Khan <shuah.kh@samsung.com>]

On 02/28/2014 03:15 PM, Greg KH wrote:
> On Thu, Feb 27, 2014 at 05:27:25PM -0700, Shuah Khan wrote:
>> usbip userspace has duplicated enum definition to report usbip device
>> status maintained by the kernel. Adding an usbip uapi header file will
>> define the kernel - userspace interface for this device status.
>>
>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>> ---
>>   include/uapi/linux/Kbuild  |    1 +
>>   include/uapi/linux/usbip.h |   26 ++++++++++++++++++++++++++
>>   2 files changed, 27 insertions(+)
>>   create mode 100644 include/uapi/linux/usbip.h
>
> Staging code should be self-contained within drivers/staging/
>
> Now I know that a bunch of people are now working on this codebase, and
> hopefully it will finally get moved out of staging someday soon, but
> until then, I can't add this file in this location, sorry.

That makes sense.

>
> Look at how the drivers/staging/android code handles the uapi files, you
> should try doing that instead.
>

I will take a look at how android is handling uapi files and redo this 
patch series and resend it. Hope everybody is ok with the code itself, 
just the location of the uapi file is the issue, if not please let me 
know and give me feedback on the approach.

-- Shuah


-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658