Re: [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

On 03/01/2014 12:40 AM, Markus Armbruster wrote:
> Visitors get passed a pointer to the visited object.  The generated
> visitors try to cope with this pointer being null in some places, for
> instance like this:
> 
>     visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err);
> 
> visit_start_optional() passes its second argument to Visitor method
> start_optional.  Three out of three methods dereference it
> unconditionally.
> 
> I fail to see how hits pointer could legitimately be null.

s/hits/this/

> 
> All this useless null checking is highly redundant, which Coverity
> duly reports.  About 200 times.
> 
> Remove the useless null checks.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Still stands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]