From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH] ceph: fix ceph_dir_llseek() Date: Sat, 01 Mar 2014 19:06:55 -0600 Message-ID: <5312842F.9040505@ieee.org> References: <1393492047-18261-1-git-send-email-zheng.z.yan@intel.com> <5310978F.2000705@ieee.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f180.google.com ([209.85.192.180]:44086 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352AbaCBBHC (ORCPT ); Sat, 1 Mar 2014 20:07:02 -0500 Received: by mail-pd0-f180.google.com with SMTP id v10so227665pde.39 for ; Sat, 01 Mar 2014 17:07:01 -0800 (PST) In-Reply-To: Sender: ceph-devel-owner@vger.kernel.org List-ID: To: "Yan, Zheng" Cc: "Yan, Zheng" , ceph-devel On 02/28/2014 06:14 PM, Yan, Zheng wrote: >>> >>@@ -474,7 +474,7 @@ static loff_t ceph_dir_llseek(struct file *file, loff_t offset, int whence) >>> >> { >>> >> struct ceph_file_info *fi = file->private_data; >>> >> struct inode *inode = file->f_mapping->host; >>> >>- loff_t old_offset = offset; >>> >>+ loff_t old_offset = ceph_make_fpos(fi->frag, fi->next_offset); >> > >> >Should this be named "next_offset" (or maybe "current_offset")? >> >It doesn't seem "old" to me, though I do realize it doesn't >> >necessarily represent where the "next" file position will be. >> > > No. next_offset is the position where next readdir request will be. I guess "old_next_offset" is what it is but in any case looking again I see what you mean now. Thanks. -Alex