From: Lars-Peter Clausen <lars@metafoo.de>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Joe Perches <joe@perches.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [iio:togreg 3/3] WARNING: Reusing the krealloc arg is almost always a bug
Date: Sun, 02 Mar 2014 10:11:24 +0100 [thread overview]
Message-ID: <5312F5BC.7080607@metafoo.de> (raw)
In-Reply-To: <20140302022404.GA16141@localhost>
On 03/02/2014 03:24 AM, Fengguang Wu wrote:
>
> Hi Lars-Peter,
>
> FYI, there are new warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> head: bdc8cda1d010887c06bd8c29564b74cd61ec0a7b
> commit: bdc8cda1d010887c06bd8c29564b74cd61ec0a7b [3/3] iio:adc: Add Xilinx XADC driver
>
> scripts/checkpatch.pl 0001-iio-adc-Add-Xilinx-XADC-driver.patch
> # many are suggestions rather than must-fix
> WARNING: Reusing the krealloc arg is almost always a bug
> #1220: drivers/iio/adc/xilinx-xadc-core.c:1138:
> + indio_dev->channels = krealloc(channels, sizeof(*channels) *
>
This is actually a false positive, checkpatch thinks that
'indio_dev->channels' and 'channels' is the same. Added Joe to Cc.
- Lars
next parent reply other threads:[~2014-03-02 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53124ca5.kw+3caZ7enyrhSmq%fengguang.wu@intel.com>
[not found] ` <20140302022404.GA16141@localhost>
2014-03-02 9:11 ` Lars-Peter Clausen [this message]
2014-03-02 12:06 ` [iio:togreg 3/3] WARNING: Reusing the krealloc arg is almost always a bug Joe Perches
2014-03-02 13:35 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5312F5BC.7080607@metafoo.de \
--to=lars@metafoo.de \
--cc=fengguang.wu@intel.com \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.