Re: [PATCH] x86_pkg_temp_thermal: Do not expose as a hwmon device

[Guenter Roeck <linux@roeck-us.net>]

On 03/02/2014 09:04 AM, Jean Delvare wrote:
> On Sun, 02 Mar 2014 08:03:28 -0800, Guenter Roeck wrote:
>> On 03/02/2014 06:33 AM, Jean Delvare wrote:
>>> The temperature value reported by x86_pkg_temp_thermal is already
>>> reported by the coretemp driver. So, do not expose this thermal zone
>>> as a hwmon device, because it would be redundant.
>>>
>>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>>> Cc: Zhang Rui <rui.zhang@intel.com>
>>> Cc: Eduardo Valentin <eduardo.valentin@ti.com>
>>
>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Does that make the "Fix thermal zone type" patch unnecessary ?
>
> I think both patches are needed, as type "pkg-temp-0" is wrong anyway,
> regardless of the hwmon side of things. But it is less important with
> this patch applied, indeed.
>
>> If so, this patch would be a candidate for stable.
>
> I'm still not 100% certain we want either patch in stable. After all,
> they aren't fixing any critical bug, and they change user interfaces so
> they could impact some users in unpredictable ways.
>

Ok.

Guenter