From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] vlc: avoid that AUTORECONF renames configure's arguments
Date: Mon, 03 Mar 2014 07:42:13 +0100 [thread overview]
Message-ID: <53142445.9040006@mind.be> (raw)
In-Reply-To: <20140301145442.7e99ba17@skate>
On 01/03/14 14:54, Thomas Petazzoni wrote:
> Arnout,
>
> On Thu, 27 Feb 2014 20:37:34 +0100, Arnout Vandecappelle
> (Essensium/Mind) wrote:
>> VLC defines two autoconf functions which are also defined by our own
>> pkg.m4 from pkgconf. Unfortunately, they are defined in a different way:
>> VLC adds --enable- options, but pkg.m4 adds --with- options. To make
>> sure we use VLC's definition, rename these two functions from
>> PKG_WITH_MODULES to VLC_PKG_WITH_MODULES and from PKG_HAVE_WITH_MODULES
>> to VLC_PKG_HAVE_WITH_MODULES.
>>
>> Note that the second function (PKG_HAVE_WITH_MODULES) is in fact
>> defined in exactly the same way by VLC and pkgconf, but this might no
>> longer be the case when either pkgconf or VLC is updated. Therefore,
>> that one is renamed as well.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>> ---
>> I propose to apply this to next but not to master - Simon's patch 02004773
>> has been applied to master and fixes it as well. However, that means that
>> 02004773 has to be reverted when next is merged into master.
>
> Thanks, patch applied, after reverting 02004773. Please let me know if
> the revert was correct, as there was a minor conflict with some udev
> related changes.
Looks good to me. Autobuilders will tell us if it's not.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2014-03-03 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 19:37 [Buildroot] [PATCH] vlc: avoid that AUTORECONF renames configure's arguments Arnout Vandecappelle
2014-02-27 20:09 ` Simon Dawson
2014-03-01 13:54 ` Thomas Petazzoni
2014-03-03 6:42 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53142445.9040006@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.