From: Richard Weinberger <richard@nod.at>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 01/44] arc: Use get_signal() signal_setup_done()
Date: Mon, 03 Mar 2014 10:04:39 +0100 [thread overview]
Message-ID: <531445A7.1090001@nod.at> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA2307517FC80@IN01WEMBXA.internal.synopsys.com>
Am 03.03.2014 09:44, schrieb Vineet Gupta:
> On Monday 03 March 2014 05:26 AM, Richard Weinberger wrote:
>> Use the more generic functions get_signal() signal_setup_done()
>> for signal delivery.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>
> I gave the git branch some light testing and it works well.
Thx!
> Minor comment below, otherwise
>
> Acked-by: Vineet Gupta <vgupta@synopsys.com>
>
> P.S. Since this depends on translate_sig change, I can't possibly take it via ARC
> tree.
I hope we can merge this via Al's signal.git tree.
> Thx,
> -Vineet
>
>> ---
>> arch/arc/kernel/signal.c | 39 +++++++++++++++------------------------
>> 1 file changed, 15 insertions(+), 24 deletions(-)
>>
>> diff --git a/arch/arc/kernel/signal.c b/arch/arc/kernel/signal.c
>> index 7e95e1a..c2031e2 100644
>> --- a/arch/arc/kernel/signal.c
>> +++ b/arch/arc/kernel/signal.c
>> @@ -179,14 +179,13 @@ static inline int map_sig(int sig)
>> }
>>
>> static int
>> -setup_rt_frame(int signo, struct k_sigaction *ka, siginfo_t *info,
>> - sigset_t *set, struct pt_regs *regs)
>> +setup_rt_frame(struct ksignal *ksig, sigset_t *set, struct pt_regs *regs)
>> {
>> struct rt_sigframe __user *sf;
>> unsigned int magic = 0;
>> int err = 0;
>>
>> - sf = get_sigframe(ka, regs, sizeof(struct rt_sigframe));
>> + sf = get_sigframe(&ksig->ka, regs, sizeof(struct rt_sigframe));
>
> Can we pass ksig pointer kere (and a pairing change to get_sigframe). This will
> reduce the code churn when we do the sigsp() change in there.
Will do!
Thanks,
//richard
next prev parent reply other threads:[~2014-03-03 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 23:55 Global signal cleanup, take 2 Richard Weinberger
2014-03-02 23:55 ` [PATCH 01/44] arc: Use get_signal() signal_setup_done() Richard Weinberger
2014-03-03 8:44 ` Vineet Gupta
2014-03-03 9:04 ` Richard Weinberger [this message]
2014-03-22 7:03 ` Vineet Gupta
2014-03-02 23:55 ` [PATCH 02/44] arm64: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 03/44] avr32: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 04/44] blackfin: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 05/44] c6x: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 06/44] cris: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 07/44] frv: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 08/44] hexagon: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 09/44] ia64: " Richard Weinberger
2014-03-02 23:55 ` [PATCH 10/44] m32r: " Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531445A7.1090001@nod.at \
--to=richard@nod.at \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.