All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kbuild: tools: fix a bug that always builds Denx logo
Date: Mon, 3 Mar 2014 18:09:42 +0800	[thread overview]
Message-ID: <531454E6.5010907@atmel.com> (raw)
In-Reply-To: <1393839656-24891-1-git-send-email-yamada.m@jp.panasonic.com>

Hi Masahiro Yamada,

On 03/03/2014 05:40 PM, Masahiro Yamada wrote:
> LOGO_BMP was never overwritten by board-specific or
> vendor-specific logos.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Reported-by: Bo Shen <voice.shen@atmel.com>
> ---
>   tools/Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Bo Shen <voice.shen@atmel.com>

> diff --git a/tools/Makefile b/tools/Makefile
> index dcd49f8..6af1f33 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -157,10 +157,10 @@ ifeq ($(LOGO_BMP),)
>   LOGO_BMP= $(srctree)/$(src)/logos/denx.bmp
>
>   # Use board logo and fallback to vendor
> -ifneq ($(wildcard logos/$(BOARD).bmp),)
> +ifneq ($(wildcard $(srctree)/$(src)/logos/$(BOARD).bmp),)
>   LOGO_BMP= $(srctree)/$(src)/logos/$(BOARD).bmp
>   else
> -ifneq ($(wildcard logos/$(VENDOR).bmp),)
> +ifneq ($(wildcard $(srctree)/$(src)/logos/$(VENDOR).bmp),)
>   LOGO_BMP= $(srctree)/$(src)/logos/$(VENDOR).bmp
>   endif
>   endif
>

Best Regards,
Bo Shen

  reply	other threads:[~2014-03-03 10:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03  9:40 [U-Boot] [PATCH] kbuild: tools: fix a bug that always builds Denx logo Masahiro Yamada
2014-03-03 10:09 ` Bo Shen [this message]
2014-03-04 19:19 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531454E6.5010907@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.