All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
	"Hoyer, David" <David.Hoyer@netapp.com>,
	"Qemu-devel@nongnu.org" <Qemu-devel@nongnu.org>
Cc: "Moyer, Keith" <Keith.Moyer@netapp.com>,
	"Best, Tish" <Tish.Best@netapp.com>
Subject: Re: [Qemu-devel] e1000 memory corruption in guest OS
Date: Mon, 03 Mar 2014 12:21:21 +0100	[thread overview]
Message-ID: <531465B1.1090605@redhat.com> (raw)
In-Reply-To: <53145DD4.4040101@ozlabs.ru>

Il 03/03/2014 11:47, Alexey Kardashevskiy ha scritto:
> > > Sorry, I am not following you here. Does KVM map things not page-aligned?
> >
> > Look in exec.c for xen_enabled().  Xen's implementation of
> > address_space_map/unmap is completely different.
>
> Honestly cannot see much difference in the current QEMU...

void *qemu_get_ram_ptr(ram_addr_t addr)
{
     RAMBlock *block = qemu_get_ram_block(addr);

     if (xen_enabled()) {
         /* We need to check if the requested address is in the RAM
          * because we don't want to map the entire memory in QEMU.
          * In that case just map until the end of the page.
          */
         if (block->offset == 0) {
             return xen_map_cache(addr, 0, 0);
         } else if (block->host == NULL) {
             block->host =
                 xen_map_cache(block->offset, block->length, 1);
         }
     }
     return block->host + (addr - block->offset);
}

Paolo

  reply	other threads:[~2014-03-03 11:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-16  4:29 [Qemu-devel] e1000 memory corruption in guest OS Hoyer, David
2014-02-24  4:20 ` Alexey Kardashevskiy
2014-03-01 12:30   ` Alexey Kardashevskiy
2014-03-01 21:31     ` Paolo Bonzini
2014-03-03  1:58       ` Alexey Kardashevskiy
2014-03-03  8:33         ` Paolo Bonzini
2014-03-03 10:47           ` Alexey Kardashevskiy
2014-03-03 11:21             ` Paolo Bonzini [this message]
2014-03-03 21:33             ` Don Slutz
2014-03-03 22:53               ` Alexey Kardashevskiy
2014-02-24 14:02 ` Paolo Bonzini
2014-02-24 14:15   ` Hoyer, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531465B1.1090605@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=David.Hoyer@netapp.com \
    --cc=Keith.Moyer@netapp.com \
    --cc=Qemu-devel@nongnu.org \
    --cc=Tish.Best@netapp.com \
    --cc=aik@ozlabs.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.