From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>, Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] qemu-img convert cache mode for source
Date: Mon, 03 Mar 2014 13:59:59 +0100 [thread overview]
Message-ID: <53147CCF.1070600@redhat.com> (raw)
In-Reply-To: <53146596.90505@kamp.de>
Il 03/03/2014 12:20, Peter Lieven ha scritto:
>>>
>> This #ifdef should be in the raw-posix driver. Please try to keep the
>> qemu interface backend agnostic and leave POSIX_FADV_DONTNEED and
>> friends as an implementation detail of block drivers.
> I had the same idee, but as far as I see the callback to the completes
> request is handled in block.c. raw-posix uses the aio interface and
> not coroutines.
You can put it in the QEMU_AIO_READ case of aio_worker.
linux-aio.c is only for O_DIRECT, so you do not need it there.
BTW, perhaps you need to exclude the fadvise if O_DIRECT is in use?
Paolo
next prev parent reply other threads:[~2014-03-03 13:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 10:14 [Qemu-devel] qemu-img convert cache mode for source Peter Lieven
2014-02-26 15:41 ` Stefan Hajnoczi
2014-02-26 15:54 ` Eric Blake
2014-02-26 16:01 ` Peter Lieven
2014-02-27 8:57 ` Stefan Hajnoczi
2014-02-28 14:35 ` Peter Lieven
2014-03-03 10:38 ` Kevin Wolf
2014-03-03 11:20 ` Peter Lieven
2014-03-03 12:59 ` Paolo Bonzini [this message]
2014-03-03 13:07 ` Peter Lieven
2014-03-03 12:03 ` Stefan Hajnoczi
2014-03-03 12:20 ` Peter Lieven
2014-03-04 9:24 ` Stefan Hajnoczi
2014-03-05 14:44 ` Peter Lieven
2014-03-05 15:20 ` Marcus
2014-03-05 15:53 ` Peter Lieven
2014-03-05 17:38 ` Marcus
2014-03-05 18:09 ` Peter Lieven
2014-03-06 10:41 ` Stefan Hajnoczi
2014-03-06 18:58 ` Peter Lieven
2014-03-06 10:29 ` Stefan Hajnoczi
2014-03-06 11:29 ` Paolo Bonzini
2014-03-06 14:19 ` Liguori, Anthony
2014-03-06 18:07 ` Peter Lieven
2014-03-07 8:03 ` Peter Lieven
2014-02-27 1:10 ` Fam Zheng
2014-02-27 11:07 ` Kevin Wolf
2014-02-27 16:12 ` Peter Lieven
2014-03-03 10:40 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53147CCF.1070600@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.