All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Markus Pargmann <mpa@pengutronix.de>, Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] watchdog: core: module param to activate watchdog
Date: Mon, 03 Mar 2014 06:38:08 -0800	[thread overview]
Message-ID: <531493D0.9000805@roeck-us.net> (raw)
In-Reply-To: <20140303110932.GD24953@pengutronix.de>

>> To achieve what you want you should make sure that your "BIOS" starts
>> with the watchdog enabled and with a very long watchdog heartbeat (so
>> that it doesn't need to get pinged). Then the kernel can boot and
>> userspace can start and then you can do the necessary with the
>> /dev/watchdog functionality. Only thing you need to take care of is
>> that you don't stop the watchdog (via a module param or something
>> similar) during the probe/init of the driver.
>> I believe we allready have a winbond driver doing that. Just checked:
>> it's w83697hf_wdt.c with the early_disable module parameter.
>>
>> So, this is something that needs to be taken into account during
>> probe/init of the driver and for each watchdog that needs it.
>> And thus not for the first watchdog that get's registered.
>> Furthermore: not all watchdog devices have a heartbeat that is long
>> enough to achieve this functionality.
>
> Okay, thanks for the clarification. So I will change the driver and add
> an appropriate paramter to it instead as the winbond driver does.
>

Other drivers do the same, but don't even have a module parameter to
disable it if it is already running. They just ping the watchdog during
initialization to delay the timeout. w83627hf_wdt.c is an example.

Guenter


      reply	other threads:[~2014-03-03 14:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 16:16 [PATCH] watchdog: core: module param to activate watchdog Markus Pargmann
2014-03-02  5:11 ` Guenter Roeck
2014-03-03  9:39   ` Markus Pargmann
2014-03-02  9:43 ` Wim Van Sebroeck
2014-03-03  9:27   ` Markus Pargmann
2014-03-03 10:19     ` Wim Van Sebroeck
2014-03-03 11:09       ` Markus Pargmann
2014-03-03 14:38         ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531493D0.9000805@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=kernel@pengutronix.de \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.