From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKW4W-00044e-Rk for qemu-devel@nongnu.org; Mon, 03 Mar 2014 11:50:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKW4N-0000pl-3l for qemu-devel@nongnu.org; Mon, 03 Mar 2014 11:50:32 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41556 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKW4M-0000pc-QB for qemu-devel@nongnu.org; Mon, 03 Mar 2014 11:50:23 -0500 Message-ID: <5314B2CA.3020708@suse.de> Date: Mon, 03 Mar 2014 17:50:18 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1393313787-890-1-git-send-email-afaerber@suse.de> In-Reply-To: <1393313787-890-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v10 0/2] target-i386: X86CPU subclasses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Eduardo Habkost , Anthony Liguori , Igor Mammedov Am 25.02.2014 08:36, schrieb Andreas F=C3=A4rber: > Hello, >=20 > Here's my cleaned up version of slim x86 CPU subclasses. > Second patch didn't get a lot of testing yet. >=20 > Loading cpudef is still in main initfn since otherwise the host type > would need to be relocated. Can be cleaned up as follow-ups. >=20 > I wonder whether we are intentionally registering the host type even fo= r > !CONFIG_KVM? Instantiating it will then always lead to assertion failur= e. Ping! Did anyone review or test? Still applies after new x2apic patches. Andreas > Available for testing here: > git://github.com/afaerber/qemu-cpu.git qom-cpu-x86-subclasses.v10 > https://github.com/afaerber/qemu-cpu/commits/qom-cpu-x86-subclasses.v10 >=20 > Regards, > Andreas >=20 > v9 -> v10: > * Cleaned up documentation comments. > * Prepended patch to implement CPUClass::class_by_name(), rebased on it= . > * Cleaned up naming (..._class_init, ..._initfn, type vs. class). > * Dropped duplicate white line. > * Dropped unnecessary .abstract, .instance_size, .class_size fields. > * Aligned model type registration with other targets by having the > registration function operate on one model only. > * Relocated cpudef-based types to after x86_cpu_load_cpudef(). > * Moved assignment of cpu_def into cpudef-specific class_init. >=20 > (went through various hands, last ehabkost's) >=20 > v2 -> v3: > * Instead of re-coding all CPU definitions as class_init functions, lea= ve > the built-in definition array in place and place x86_def_t in the cla= ss. > * Use kvm_arch_init() hook to assure class_init succeeds for -cpu host. > Suggested by Eduardo. >=20 > v1-> v2: > * Instead of turning x86_def_t into X86CPUInfo to initialize classes, > drop it completely and register types manually with customizable Type= Infos > * Use new list facilities for printing -cpu ? models > * Adopt new name scheme suggested by Eduardo and ideas from my alpha se= ries > * Keep short names in -cpu ? output for alignment reasons > * Merge cpu_x86_init() into cpu.c:cpu_x86_register() > * Append patch showing Haswell as subclass of SandyBridge >=20 > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: Paolo Bonzini > Cc: Anthony Liguori >=20 > Andreas F=C3=A4rber (1): > target-i386: Prepare CPUClass::class_by_name for X86CPU >=20 > Eduardo Habkost (1): > target-i386: X86CPU model subclasses >=20 > target-i386/cpu-qom.h | 15 ++++ > target-i386/cpu.c | 197 +++++++++++++++++++++++++++++++-----------= -------- > 2 files changed, 138 insertions(+), 74 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg