From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCHv2 net-next 18/31] iw_cxgb4: ignore read reponse type 1 CQEs. Date: Mon, 03 Mar 2014 21:49:06 +0300 Message-ID: <5314CEA2.8050505@cogentembedded.com> References: <1393828875-13452-1-git-send-email-hariprasad@chelsio.com> <1393828875-13452-19-git-send-email-hariprasad@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393828875-13452-19-git-send-email-hariprasad@chelsio.com> Sender: netdev-owner@vger.kernel.org To: Hariprasad Shenai , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Cc: davem@davemloft.net, roland@purestorage.com, kumaras@chelsio.com, dm@chelsio.com, swise@opengridcomputing.com, leedom@chelsio.com, santosh@chelsio.com, nirranjan@chelsio.com List-Id: linux-rdma@vger.kernel.org Hello. On 03/03/2014 09:41 AM, Hariprasad Shenai wrote: > From: Steve Wise > These are generated by HW in some error cases and need to be > silently discarded. > Signed-off-by: Steve Wise > --- > drivers/infiniband/hw/cxgb4/cq.c | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) > diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c > index 59f7601..e310762 100644 > --- a/drivers/infiniband/hw/cxgb4/cq.c > +++ b/drivers/infiniband/hw/cxgb4/cq.c > @@ -366,6 +366,14 @@ void c4iw_flush_hw_cq(struct c4iw_cq *chp) > if (CQE_OPCODE(hw_cqe) == FW_RI_READ_RESP) { > > /* > + * If we have reached here because of async > + * event or other error, and have egress error > + * then drop > + */ The networking code multi-line comment style is: /* bla * bla */ > + if (CQE_TYPE(hw_cqe) == 1) > + goto next_cqe; > + > + /* > * drop peer2peer RTR reads. > */ > if (CQE_WRID_STAG(hw_cqe) == 1) > @@ -512,6 +520,18 @@ static int poll_cq(struct t4_wq *wq, struct t4_cq *cq, struct t4_cqe *cqe, > if (RQ_TYPE(hw_cqe) && (CQE_OPCODE(hw_cqe) == FW_RI_READ_RESP)) { > > /* > + * If we have reached here because of async > + * event or other error, and have egress error > + * then drop > + */ Likewise. WBR, Sergei