From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH] Add a "make rpmball" target
Date: Mon, 03 Mar 2014 18:46:45 -0500
Message-ID: <53151465.7090608@terremark.com>
References: <1393858780-11628-1-git-send-email-george.dunlap@eu.citrix.com>
	<5314A8AA.9000805@eu.citrix.com> <53150385.9020107@terremark.com>
	<53150B54.8070709@terremark.com>
	<alpine.DEB.2.00.1403032333460.14746@procyon.dur.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.00.1403032333460.14746@procyon.dur.ac.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: M A Young <m.a.young@durham.ac.uk>, Don Slutz <dslutz@verizon.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 03/03/14 18:37, M A Young wrote:
> On Mon, 3 Mar 2014, Don Slutz wrote:
>
>> On 03/03/14 17:34, Don Slutz wrote:
>>> On 03/03/14 11:07, George Dunlap wrote:
>>>> On 03/03/2014 02:59 PM, George Dunlap wrote:
>>>>> Build a simplistic dummy package, similar to "make debball", for
>>>>> developers on rpm-based systems.
>>>>>
>>>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>>>>
>>>> I meant to add, I've tested this running as root, but not as a normal user -- I'd appreciate it if someone could give it a try...
>>>>
>>>
>>> As a user I get:
>>> ...
>>> sh ./tools/misc/mkrpm /home/don/xen $(make -C xen xenversion | grep -v :)
>>> error: line 3: Illegal char '-' in: Version: 4.5-unstable
>>> make: *** [rpmball] Error 1
>>>
>>>    -Don Slutz
>>>
>>>
>>
>> And applying a version "fix":
>>
>>
>>
>> From 40c6b19abf44aaf7496b4c77536677fc0d463931 Mon Sep 17 00:00:00 2001
>> From: Don Slutz <dslutz@verizon.com>
>> Date: Mon, 3 Mar 2014 17:59:17 -0500
>> Subject: [PATCH] Adjust version
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
>> ---
>> Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 75e845b..6def25d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -157,7 +157,7 @@ debball: dist
>> # to be a full featured policy compliant .rpm package.
>> .PHONY: rpmball
>> rpmball: dist
>> -       sh ./tools/misc/mkrpm $(XEN_ROOT) $$($(MAKE) -C xen xenversion | grep -v :)
>> +       sh ./tools/misc/mkrpm $(XEN_ROOT) $$(git describe --long --dirty | tr - _)
>
> You can't assume git will work; it doesn't for the tarball releases.
>
>     Michael Young

How about "| cut -d- -f1":

dcs-xen-54:~/xen>make -C xen xenversion | grep -v : | cut -d- -f1
4.5


    -Don Slutz