From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKdEu-0006fq-5Z for qemu-devel@nongnu.org; Mon, 03 Mar 2014 19:29:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKdEm-00021z-QV for qemu-devel@nongnu.org; Mon, 03 Mar 2014 19:29:44 -0500 Message-ID: <53151E66.8090101@suse.de> Date: Tue, 04 Mar 2014 01:29:26 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1391265952-31788-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1391265952-31788-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 0/2] target-ppc: CPU device tree id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_?= =?ISO-8859-1?Q?F=E4rber?= Alexey Kardashevskiy wrote: > This is some cleanup. Please, comment. Thanks! > Thanks, applied to ppc-next. Please bear in mind that your target CPU finding loop doesn't scale. So make sure you don't call your new dt index helper in any code path where you care about performance. Or when you do make sure to introduce a new table for easier lookup. Alex