* [Cluster-devel] [PATCH] GFS2: return -E2BIG if hit the maximum limits of ACLs
@ 2014-03-04 3:28 Jeff Liu
2014-03-06 15:42 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Liu @ 2014-03-04 3:28 UTC (permalink / raw)
To: cluster-devel.redhat.com
From: Jie Liu <jeff.liu@oracle.com>
Return -E2BIG rather than -EINVAL if hit the maximum size limits of
ACLs, as the former errno is consistent with VFS xattr syscalls.
This is pointed out by Dave Chinner in previous discussion thread:
http://www.spinics.net/lists/linux-fsdevel/msg71125.html
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/gfs2/acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
index ba94566..9c59ebe 100644
--- a/fs/gfs2/acl.c
+++ b/fs/gfs2/acl.c
@@ -86,7 +86,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type)
BUG_ON(name == NULL);
if (acl->a_count > GFS2_ACL_MAX_ENTRIES)
- return -EINVAL;
+ return -E2BIG;
if (type == ACL_TYPE_ACCESS) {
umode_t mode = inode->i_mode;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [PATCH] GFS2: return -E2BIG if hit the maximum limits of ACLs
2014-03-04 3:28 [Cluster-devel] [PATCH] GFS2: return -E2BIG if hit the maximum limits of ACLs Jeff Liu
@ 2014-03-06 15:42 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2014-03-06 15:42 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nmw tree. Thanks,
Steve.
On Tue, 2014-03-04 at 11:28 +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Return -E2BIG rather than -EINVAL if hit the maximum size limits of
> ACLs, as the former errno is consistent with VFS xattr syscalls.
>
> This is pointed out by Dave Chinner in previous discussion thread:
> http://www.spinics.net/lists/linux-fsdevel/msg71125.html
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
> fs/gfs2/acl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
> index ba94566..9c59ebe 100644
> --- a/fs/gfs2/acl.c
> +++ b/fs/gfs2/acl.c
> @@ -86,7 +86,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type)
> BUG_ON(name == NULL);
>
> if (acl->a_count > GFS2_ACL_MAX_ENTRIES)
> - return -EINVAL;
> + return -E2BIG;
>
> if (type == ACL_TYPE_ACCESS) {
> umode_t mode = inode->i_mode;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-06 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 3:28 [Cluster-devel] [PATCH] GFS2: return -E2BIG if hit the maximum limits of ACLs Jeff Liu
2014-03-06 15:42 ` Steven Whitehouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.