From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap() Date: Tue, 4 Mar 2014 11:42:46 +0200 Message-ID: <5315A016.3090504@ti.com> References: <1393923710-10377-1-git-send-email-peter.ujfalusi@ti.com> <1393923710-10377-3-git-send-email-peter.ujfalusi@ti.com> <1393924359.866301359@f148.i.mail.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1393924359.866301359@f148.i.mail.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Alexander Shiyan Cc: Arnd Bergmann , Tony Lindgren , linux-kernel@vger.kernel.org, Santosh Shilimkar , Olof Johansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gMDMvMDQvMjAxNCAxMToxMiBBTSwgQWxleGFuZGVyIFNoaXlhbiB3cm90ZToKPiDQktGC0L7R gNC90LjQuiwgIDQg0LzQsNGA0YLQsCAyMDE0LCAxMTowMSArMDI6MDAg0L7RgiBQZXRlciBVamZh bHVzaSA8cGV0ZXIudWpmYWx1c2lAdGkuY29tPjoKPj4gV2UgY2FuIHRoZW4gcmVtb3ZlIHRoZSBp b3VubWFwKCkgY2FsbHMgZnJvbSBwcm9iZSBhbmQgcmVtb3ZlLgo+PiBTaW5jZSB0aGUgZHJpdmVy IHJlcXVlc3RzIHRoZSByZXNvdXJjZXMgdmlhIGluZGV4IHdlIGNhbiBkbyB0aGUgbWVtIHJlc291 cmNlCj4+IHJlcXVlc3Qgd2l0aGluIGEgZm9yIGxvb3AuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFBl dGVyIFVqZmFsdXNpIDxwZXRlci51amZhbHVzaUB0aS5jb20+Cj4+IFJldmlld2VkLWJ5OiBTYW50 b3NoIFNoaWxpbWthciA8c2FudG9zaC5zaGlsaW1rYXJAdGk+Cj4+IC0tLQo+IAo+PiArCS8qIEdl dCBtZW0gcmVzb3VyY2VzICovCj4+ICsJZm9yIChpID0gMDsgaSA8IDM7IGkrKykgewo+PiArCQlz dHJ1Y3QgcmVzb3VyY2UJKnJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LAo+PiArCQkJ CQkJCSAgICAgSU9SRVNPVVJDRV9NRU0sIGkpOwo+PiArCQlpZiAoIXJlcykgewo+PiArCQkJZGV2 X2VycigmcGRldi0+ZGV2LCAiY291bGRuJ3QgZmluZCByZXNvdXJjZSAlZFxuIiwgaSk7Cj4+ICsJ CQlyZXR1cm4gLUVOT0RFVjsKPj4gKwkJfQo+IAo+IE5vIG5lZWQgdG8gY2hlY2sgInJlcyIuIGRl dm1fcmVxdWVzdF9hbmRfaW9yZW1hcCgpIGRvIGFsbCBmb3IgdXMuCgpUcnVlLgoKLS0gClDDqXRl cgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Tue, 4 Mar 2014 11:42:46 +0200 Subject: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap() In-Reply-To: <1393924359.866301359@f148.i.mail.ru> References: <1393923710-10377-1-git-send-email-peter.ujfalusi@ti.com> <1393923710-10377-3-git-send-email-peter.ujfalusi@ti.com> <1393924359.866301359@f148.i.mail.ru> Message-ID: <5315A016.3090504@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/04/2014 11:12 AM, Alexander Shiyan wrote: > ???????, 4 ????? 2014, 11:01 +02:00 ?? Peter Ujfalusi : >> We can then remove the iounmap() calls from probe and remove. >> Since the driver requests the resources via index we can do the mem resource >> request within a for loop. >> >> Signed-off-by: Peter Ujfalusi >> Reviewed-by: Santosh Shilimkar >> --- > >> + /* Get mem resources */ >> + for (i = 0; i < 3; i++) { >> + struct resource *res = platform_get_resource(pdev, >> + IORESOURCE_MEM, i); >> + if (!res) { >> + dev_err(&pdev->dev, "couldn't find resource %d\n", i); >> + return -ENODEV; >> + } > > No need to check "res". devm_request_and_ioremap() do all for us. True. -- P?ter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756838AbaCDJn1 (ORCPT ); Tue, 4 Mar 2014 04:43:27 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:58966 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756613AbaCDJnY (ORCPT ); Tue, 4 Mar 2014 04:43:24 -0500 Message-ID: <5315A016.3090504@ti.com> Date: Tue, 4 Mar 2014 11:42:46 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Alexander Shiyan CC: Santosh Shilimkar , Tony Lindgren , Olof Johansson , , , Arnd Bergmann , Subject: Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap() References: <1393923710-10377-1-git-send-email-peter.ujfalusi@ti.com> <1393923710-10377-3-git-send-email-peter.ujfalusi@ti.com> <1393924359.866301359@f148.i.mail.ru> In-Reply-To: <1393924359.866301359@f148.i.mail.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2014 11:12 AM, Alexander Shiyan wrote: > Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi : >> We can then remove the iounmap() calls from probe and remove. >> Since the driver requests the resources via index we can do the mem resource >> request within a for loop. >> >> Signed-off-by: Peter Ujfalusi >> Reviewed-by: Santosh Shilimkar >> --- > >> + /* Get mem resources */ >> + for (i = 0; i < 3; i++) { >> + struct resource *res = platform_get_resource(pdev, >> + IORESOURCE_MEM, i); >> + if (!res) { >> + dev_err(&pdev->dev, "couldn't find resource %d\n", i); >> + return -ENODEV; >> + } > > No need to check "res". devm_request_and_ioremap() do all for us. True. -- Péter