From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: 3.10.X kernel/jump_label kvm Date: Tue, 04 Mar 2014 11:01:18 +0100 Message-ID: <5315A46E.7000509@siemens.com> References: <5310E7E8.1040508@profihost.ag> <5314AF7B.10903@redhat.com> <5314C752.1070407@profihost.ag> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit To: Stefan Priebe , Paolo Bonzini , kvm@vger.kernel.org Return-path: Received: from david.siemens.de ([192.35.17.14]:58287 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756511AbaCDKBZ (ORCPT ); Tue, 4 Mar 2014 05:01:25 -0500 In-Reply-To: <5314C752.1070407@profihost.ag> Sender: kvm-owner@vger.kernel.org List-ID: On 2014-03-03 19:17, Stefan Priebe wrote: > > Am 03.03.2014 17:36, schrieb Paolo Bonzini: >> Il 28/02/2014 20:47, Stefan Priebe ha scritto: >>> Hello, >>> >>> i got this stack trace multiple times while using a vanilla 3.10.32 >>> kernel and already sent it to the list in december but got no replies. >> >> Please try the patch of commit 0dce7cd67fd9055c4a2ff278f8af1431e646d346: > > Thanks - will try it. So this one should also go into 3.10.X It's part of 3.10.29. Only .26..28 were affected by the regression below. Jan >> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c >> index 1673940cf9c3..775702f649ca 100644 >> --- a/arch/x86/kvm/lapic.c >> +++ b/arch/x86/kvm/lapic.c >> @@ -1355,7 +1355,7 @@ void kvm_lapic_set_base(struct kvm_vcpu *vcpu, u64 >> value) >> vcpu->arch.apic_base = value; >> >> /* update jump label if enable bit changes */ >> - if ((vcpu->arch.apic_base ^ value) & MSR_IA32_APICBASE_ENABLE) { >> + if ((old_value ^ value) & MSR_IA32_APICBASE_ENABLE) { >> if (value & MSR_IA32_APICBASE_ENABLE) >> static_key_slow_dec_deferred(&apic_hw_disabled); >> else >> >> Paolo -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux