From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [gfs2_edit PATCH] gfs2_edit: mark log headers with the unmounted flag
Date: Tue, 04 Mar 2014 11:43:29 +0000 [thread overview]
Message-ID: <5315BC61.5050409@redhat.com> (raw)
In-Reply-To: <376888520.8664748.1393881422350.JavaMail.zimbra@redhat.com>
Hi Bob,
On 03/03/14 21:17, Bob Peterson wrote:
> Hi,
>
> This patch prints out "[UNMOUNTED]" next to log headers that have the
> unmounted flag set. That makes it much easier to determine the active
> part of a journal.
Looks good to me.
Cheers,
Andy
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/gfs2/edit/journal.c b/gfs2/edit/journal.c
> index 118d068..4dab61c 100644
> --- a/gfs2/edit/journal.c
> +++ b/gfs2/edit/journal.c
> @@ -573,10 +573,13 @@ void dump_journal(const char *journal, int tblk)
> check_journal_wrap(lh.lh_sequence,
> &highest_seq);
> print_gfs2("0x%llx (j+%4llx): Log header: Seq"
> - ": 0x%x, tail: 0x%x, blk: 0x%x",
> + ": 0x%x, tail: 0x%x, blk: 0x%x%s",
> abs_block, ((jb + wrappt) % j_size)
> / sbd.bsize, lh.lh_sequence,
> - lh.lh_tail, lh.lh_blkno);
> + lh.lh_tail, lh.lh_blkno,
> + lh.lh_flags ==
> + GFS2_LOG_HEAD_UNMOUNT ?
> + " [UNMOUNTED]" : "");
> }
> eol(0);
> } else if (sbd.gfs1 && ld_blocks > 0) {
>
next prev parent reply other threads:[~2014-03-04 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <212803250.8664536.1393881387405.JavaMail.zimbra@redhat.com>
2014-03-03 21:17 ` [Cluster-devel] [gfs2_edit PATCH] gfs2_edit: mark log headers with the unmounted flag Bob Peterson
2014-03-04 11:43 ` Andrew Price [this message]
2014-03-07 13:29 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315BC61.5050409@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.