From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: jcody@redhat.com, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)
Date: Tue, 04 Mar 2014 13:55:37 +0100 [thread overview]
Message-ID: <5315CD49.8030500@redhat.com> (raw)
In-Reply-To: <1393532883-12585-1-git-send-email-sw@weilnetz.de>
Il 27/02/2014 21:28, Stefan Weil ha scritto:
> Comment from Makefile.objs:
>
> # block-obj-y is code used by both qemu system emulation and qemu-img
>
> The system emulation needs this dependency (which was missing in Makefile),
> otherwise builds without tools (or massive parallel builds) fail.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index a28a3c8..a0dafbf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,6 +159,7 @@ qemu-options.def: $(SRC_PATH)/qemu-options.hx
> SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
> SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
>
> +$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
> $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
>
> subdir-%:
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2014-03-04 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 20:28 [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build) Stefan Weil
2014-03-04 12:55 ` Paolo Bonzini [this message]
2014-03-04 13:10 ` Peter Maydell
2014-03-04 13:35 ` Stefan Weil
2014-03-04 14:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315CD49.8030500@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.