From: Waiman Long <waiman.long@hp.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
kvm@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Michel Lespinasse <walken@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
xen-devel@lists.xenproject.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Scott J Norton <scott.norton@hp.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Wright <chrisw@sous-sol.org>,
Alok Kataria <akataria@vmware.com>,
Aswin Chandramouleeswaran <aswin@hp.com>,
Chegu Vinod <chegu_vinod@hp.com>
Subject: Re: [PATCH v5 3/8] qspinlock, x86: Add x86 specific optimization for 2 contending tasks
Date: Tue, 04 Mar 2014 09:54:05 -0500 [thread overview]
Message-ID: <5315E90D.4020801@hp.com> (raw)
In-Reply-To: <20140302131638.GB13206@redhat.com>
On 03/02/2014 08:16 AM, Oleg Nesterov wrote:
> On 02/26, Waiman Long wrote:
>> @@ -144,7 +317,7 @@ static __always_inline int queue_spin_setlock(struct qspinlock *lock)
>> int qlcode = atomic_read(lock->qlcode);
>>
>> if (!(qlcode& _QSPINLOCK_LOCKED)&& (atomic_cmpxchg(&lock->qlcode,
>> - qlcode, qlcode|_QSPINLOCK_LOCKED) == qlcode))
>> + qlcode, code|_QSPINLOCK_LOCKED) == qlcode))
> Hmm. didn't read the patch, but this change looks like accidental typo...
>
> Oleg.
>
Thank for catching that typo error. That generic code wasn't compiled in
and so I missed it. I will fix that in the next version.
-Longman
WARNING: multiple messages have this Message-ID (diff)
From: Waiman Long <waiman.long@hp.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
kvm@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Michel Lespinasse <walken@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
xen-devel@lists.xenproject.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Scott J Norton <scott.norton@hp.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Wright <chrisw@sous-sol.org>,
Alok Kataria <akataria@vmware.com>,
Aswin Chandramouleeswaran <aswin@hp.com>,
Chegu Vinod <chegu_vinod@hp.com>, Boris Ostrovsky <
Subject: Re: [PATCH v5 3/8] qspinlock, x86: Add x86 specific optimization for 2 contending tasks
Date: Tue, 04 Mar 2014 09:54:05 -0500 [thread overview]
Message-ID: <5315E90D.4020801@hp.com> (raw)
In-Reply-To: <20140302131638.GB13206@redhat.com>
On 03/02/2014 08:16 AM, Oleg Nesterov wrote:
> On 02/26, Waiman Long wrote:
>> @@ -144,7 +317,7 @@ static __always_inline int queue_spin_setlock(struct qspinlock *lock)
>> int qlcode = atomic_read(lock->qlcode);
>>
>> if (!(qlcode& _QSPINLOCK_LOCKED)&& (atomic_cmpxchg(&lock->qlcode,
>> - qlcode, qlcode|_QSPINLOCK_LOCKED) == qlcode))
>> + qlcode, code|_QSPINLOCK_LOCKED) == qlcode))
> Hmm. didn't read the patch, but this change looks like accidental typo...
>
> Oleg.
>
Thank for catching that typo error. That generic code wasn't compiled in
and so I missed it. I will fix that in the next version.
-Longman
next prev parent reply other threads:[~2014-03-04 14:54 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 4:32 [PATCH v5 0/8] qspinlock: a 4-byte queue spinlock with PV support Waiman Long
2014-02-27 4:32 ` [PATCH v5 1/8] qspinlock: Introducing a 4-byte queue spinlock implementation Waiman Long
2014-03-02 13:12 ` Oleg Nesterov
2014-03-02 13:12 ` Oleg Nesterov
2014-03-04 14:46 ` Waiman Long
2014-03-04 14:46 ` Waiman Long
2014-03-04 14:46 ` Waiman Long
2014-03-02 13:31 ` Oleg Nesterov
2014-03-02 13:31 ` Oleg Nesterov
2014-03-04 14:58 ` Waiman Long
2014-03-04 14:58 ` Waiman Long
2014-03-04 14:58 ` Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-02-27 4:32 ` [PATCH v5 2/8] qspinlock, x86: Enable x86-64 to use queue spinlock Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-03-02 14:10 ` Oleg Nesterov
2014-03-04 15:06 ` Waiman Long
2014-03-04 15:06 ` Waiman Long
2014-03-04 15:06 ` Waiman Long
2014-03-02 14:10 ` Oleg Nesterov
2014-02-27 4:32 ` [PATCH v5 3/8] qspinlock, x86: Add x86 specific optimization for 2 contending tasks Waiman Long
2014-03-02 13:16 ` Oleg Nesterov
2014-03-02 13:16 ` Oleg Nesterov
2014-03-04 14:54 ` Waiman Long
2014-03-04 14:54 ` Waiman Long [this message]
2014-03-04 14:54 ` Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-02-27 4:32 ` [PATCH RFC v5 4/8] pvqspinlock, x86: Allow unfair spinlock in a real PV environment Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-02-27 4:32 ` [PATCH RFC v5 5/8] pvqspinlock, x86: Enable unfair queue spinlock in a KVM guest Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-02-27 4:32 ` [PATCH RFC v5 6/8] pvqspinlock, x86: Rename paravirt_ticketlocks_enabled Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-02-27 4:32 ` [PATCH RFC v5 7/8] pvqspinlock, x86: Add qspinlock para-virtualization support Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-02-27 4:32 ` [PATCH RFC v5 8/8] pvqspinlock, x86: Enable KVM to use qspinlock's PV support Waiman Long
2014-02-27 4:32 ` Waiman Long
2014-02-27 8:37 ` [PATCH v5 0/8] qspinlock: a 4-byte queue spinlock with " Peter Zijlstra
2014-02-27 8:37 ` Peter Zijlstra
2014-02-27 18:25 ` Waiman Long
2014-02-27 18:25 ` Waiman Long
2014-02-27 18:25 ` Waiman Long
2014-02-27 8:37 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2014-02-26 15:14 Waiman Long
2014-02-26 15:14 ` [PATCH v5 3/8] qspinlock, x86: Add x86 specific optimization for 2 contending tasks Waiman Long
2014-02-26 15:14 ` Waiman Long
2014-02-26 16:20 ` Peter Zijlstra
2014-02-26 16:20 ` Peter Zijlstra
2014-02-27 20:42 ` Waiman Long
2014-02-28 9:29 ` Peter Zijlstra
2014-02-28 9:29 ` Peter Zijlstra
2014-02-28 16:25 ` Linus Torvalds
2014-02-28 17:37 ` Peter Zijlstra
2014-02-28 17:37 ` Peter Zijlstra
2014-02-28 16:25 ` Linus Torvalds
2014-02-28 16:38 ` Waiman Long
2014-02-28 16:38 ` Waiman Long
2014-02-28 17:56 ` Peter Zijlstra
2014-02-28 17:56 ` Peter Zijlstra
2014-03-03 17:43 ` Peter Zijlstra
2014-03-03 17:43 ` Peter Zijlstra
2014-03-04 15:27 ` Waiman Long
2014-03-04 15:27 ` Waiman Long
2014-03-04 16:58 ` Peter Zijlstra
2014-03-04 18:09 ` Peter Zijlstra
2014-03-04 18:09 ` Peter Zijlstra
2014-03-04 16:58 ` Peter Zijlstra
2014-03-04 17:48 ` Waiman Long
2014-03-04 17:48 ` Waiman Long
2014-03-04 22:40 ` Peter Zijlstra
2014-03-04 22:40 ` Peter Zijlstra
2014-03-05 20:59 ` Peter Zijlstra
2014-03-05 20:59 ` Peter Zijlstra
2014-02-27 20:42 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315E90D.4020801@hp.com \
--to=waiman.long@hp.com \
--cc=akataria@vmware.com \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=chegu_vinod@hp.com \
--cc=chrisw@sous-sol.org \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=walken@google.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.