All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Michele Paolino <m.paolino@virtualopensystems.com>,
	kvmarm@lists.cs.columbia.edu, tech@virtualopensystems.com,
	kvm@vger.kernel.org
Subject: Re: [PATCH] [fix] kernel does not compile without CONFIG_KVM_ARM_VGIC
Date: Tue, 04 Mar 2014 16:31:30 +0100	[thread overview]
Message-ID: <5315F1D2.8070305@redhat.com> (raw)
In-Reply-To: <1393945842-6453-1-git-send-email-m.paolino@virtualopensystems.com>

Il 04/03/2014 16:10, Michele Paolino ha scritto:
> When the kernel is configured without CONFIG_KVM_ARM_VGIC, the
> compilation process fails with :
>
> arch/arm/kvm/arm.c: In function 'kvm_vm_ioctl_set_device_addr':
> arch/arm/kvm/arm.c:797:3: error: implicit declaration of
>   function 'kvm_vgic_addr' [-Werror=implicit-function-declaration]
>    return kvm_vgic_addr(kvm, type, &dev_addr->addr, true)
>
> Signed-off-by: Michele Paolino <m.paolino@virtualopensystems.com>
> ---
>  include/kvm/arm_vgic.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
> index be85127..0bab057 100644
> --- a/include/kvm/arm_vgic.h
> +++ b/include/kvm/arm_vgic.h
> @@ -143,8 +143,8 @@ struct kvm_vcpu;
>  struct kvm_run;
>  struct kvm_exit_mmio;
>
> -#ifdef CONFIG_KVM_ARM_VGIC
>  int kvm_vgic_addr(struct kvm *kvm, unsigned long type, u64 *addr, bool write);
> +#ifdef CONFIG_KVM_ARM_VGIC
>  int kvm_vgic_hyp_init(void);
>  int kvm_vgic_init(struct kvm *kvm);
>  int kvm_vgic_create(struct kvm *kvm);
>

Christoffer, Marc, I can queue this directly for kvm/master if it's okay 
for you.

Paolo

  reply	other threads:[~2014-03-04 15:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 15:10 [PATCH] [fix] kernel does not compile without CONFIG_KVM_ARM_VGIC Michele Paolino
2014-03-04 15:31 ` Paolo Bonzini [this message]
2014-03-06  3:30   ` Marc Zyngier
2014-03-12 22:31     ` Christoffer Dall
2014-03-12 22:32     ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5315F1D2.8070305@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=m.paolino@virtualopensystems.com \
    --cc=tech@virtualopensystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.