From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKw14-0007zl-T9 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 15:32:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKw10-0001HU-7X for qemu-devel@nongnu.org; Tue, 04 Mar 2014 15:32:42 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37875 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKw10-0001H8-0b for qemu-devel@nongnu.org; Tue, 04 Mar 2014 15:32:38 -0500 Message-ID: <53163862.7080109@suse.de> Date: Tue, 04 Mar 2014 21:32:34 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1393901749-5944-1-git-send-email-afaerber@suse.de> In-Reply-To: <1393901749-5944-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , Fabien Chouteau Cc: Peter Maydell , Eduardo Habkost , Alexey Kardashevskiy , Sebastian Huber , qemu-devel@nongnu.org, Anthony Liguori , Igor Mammedov Am 04.03.2014 03:55, schrieb Andreas F=C3=A4rber: > Hello, >=20 > Prompted by Alexey's desire for tweakable PowerPCCPU properties but als= o by > Peter's wish for ARMCPU properties, this series sets out to align cpu_m= odel > parsing across targets. >=20 > QemuOpts would've been nice to use, but on the one hand x86 and sparc u= se > QemuOpts-incompatible +foo and -foo syntax (which accumulate rather tha= n apply > immediately) and on the other linux-user and bsd-user don't use QemuOpt= s at all. >=20 > The x86 implementation is closest to the proposed API, save for some la= ziness. > SPARC is brought in line. And as fallback for the remaining targets a n= ew > implementation, derived from x86 but supporting only key=3Dvalue format= , is added. >=20 > To facilitate using this infrastructure, a generic CPU init function is= created. >=20 > Only lightly tested. Available at: > git://github.com/afaerber/qemu-cpu.git qom-cpu-features.v1 > https://github.com/afaerber/qemu-cpu/commits/qom-cpu-features.v1 >=20 > Regards, > Andreas >=20 > Cc: Alexey Kardashevskiy > Cc: Peter Maydell > Cc: Anthony Liguori >=20 > Andreas F=C3=A4rber (6): > cpu: Introduce CPUClass::parse_features() hook > target-sparc: Use error_report() for CPU error reporting > target-sparc: Implement CPUClass::parse_features() for SPARCCPU > target-sparc: Defer SPARCCPU feature inference to QOM realize Mark and Fabien, forgot to CC you: Could you take a look at the sparc parts and give them some testing please? The very latest version can be found on qom-cpu-ppc branch if necessary. Thanks, Andreas > cpu: Implement CPUClass::parse_features() for the rest of CPUs > cpu: Factor out cpu_generic_init() >=20 > include/qom/cpu.h | 14 +++++++ > qom/cpu.c | 72 +++++++++++++++++++++++++++++++++- > target-arm/helper.c | 14 +------ > target-cris/cpu.c | 13 +----- > target-i386/cpu.c | 36 ++++++++++------- > target-lm32/helper.c | 13 +----- > target-moxie/cpu.c | 13 +----- > target-openrisc/cpu.c | 13 +----- > target-ppc/translate_init.c | 21 +--------- > target-sh4/cpu.c | 13 +----- > target-sparc/cpu.c | 96 +++++++++++++++++++++++++++----------= -------- > target-unicore32/helper.c | 13 ++---- > 12 files changed, 174 insertions(+), 157 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg