From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [PATCH v10 1/7] Add CAN FD infrastructure for CAN driver
Date: Tue, 04 Mar 2014 22:32:49 +0100 [thread overview]
Message-ID: <53164681.5000802@pengutronix.de> (raw)
In-Reply-To: <53164414.2070903@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
On 03/04/2014 10:22 PM, Oliver Hartkopp wrote:
>> - 5/7
>> In can_changelink(), when setting the data bittining, I removed the call to
>> priv->do_set_data_bittiming().
>
> I think the call to priv->do_set_data_bittiming() has to remain here to be
> consistent to priv->do_set_bittiming() in the same function.
>
> When priv->do_set_[data_]bittiming() is to be removed in the future it should
> be removed for both functions in the same way to prevent confusion.
Okay, however I'll reject every driver using
priv->do_set_[data_]bittiming anyways :P
>> Further I moved the new "if (data[IFLA_CAN_DATA_BITTIMING])" at the bottom,
>> so that all "if"s are sorted by "IFLA_".
>
> ?? You are moving the "if (data[IFLA_CAN_DATA_BITTIMING])" here and then you
> move it in 6/7 again. %-)
Doh! suppose I've squashed it into the wrong patch.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-03-04 21:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 20:44 [PATCH v10 1/7] Add CAN FD infrastructure for CAN driver Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 1/7] can: preserve skbuff protocol in can_put_echo_skb Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 2/7] can: only send bitrate data via netlink when available Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 3/7] can: move sanity check for bitrate and tq into can_get_bittiming Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 4/7] can: provide a separate bittiming_const parameter to bittiming functions Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 5/7] can: introduce the data bitrate configuration for CAN FD Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 6/7] can: allow to change the device mtu for CAN FD capable devices Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 7/7] can: add bittiming check at interface open for CAN FD Marc Kleine-Budde
2014-03-04 21:22 ` [PATCH v10 1/7] Add CAN FD infrastructure for CAN driver Oliver Hartkopp
2014-03-04 21:32 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53164681.5000802@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.