From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKxk7-0000Ke-9J for qemu-devel@nongnu.org; Tue, 04 Mar 2014 17:23:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKxk1-0007Qd-48 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 17:23:19 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39867 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKxk0-0007QW-TT for qemu-devel@nongnu.org; Tue, 04 Mar 2014 17:23:13 -0500 Message-ID: <5316524E.9050200@suse.de> Date: Tue, 04 Mar 2014 23:23:10 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <53164EAA.4030602@suse.de> In-Reply-To: <53164EAA.4030602@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next v1 1/6] ssi: Convert legacy casts from SSI_SLAVE->DEVICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Am 04.03.2014 23:07, schrieb Andreas F=E4rber: > Am 12.02.2014 01:27, schrieb Peter Crosthwaite: >> Convert legacy ->qdev style casts from TYPE_SSI_SLAVE to TYPE_DEVICE. >> >> Signed-off-by: Peter Crosthwaite >> --- >> >> hw/arm/spitz.c | 9 +++++---- >> hw/display/ads7846.c | 2 +- >> hw/display/ssd0323.c | 4 ++-- >> hw/misc/max111x.c | 4 ++-- >> hw/sd/ssi-sd.c | 2 +- >> 5 files changed, 11 insertions(+), 10 deletions(-) >=20 > Here's my changes, requiring to adjust 4/6: [snip] And another one blocking SSISlave::dev rename: diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c index 7be7c53..017f022 100644 --- a/hw/ssi/ssi.c +++ b/hw/ssi/ssi.c @@ -60,7 +60,7 @@ static int ssi_slave_init(DeviceState *dev) if (ssc->transfer_raw =3D=3D ssi_transfer_raw_default && ssc->cs_polarity !=3D SSI_CS_NONE) { - qdev_init_gpio_in(&s->qdev, ssi_cs_default, 1); + qdev_init_gpio_in(dev, ssi_cs_default, 1); } return ssc->init(s); Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg