From: Saul Wold <sgw@linux.intel.com>
To: Andrey Belous <abelous@broadcom.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com>
Date: Tue, 04 Mar 2014 15:05:14 -0800 [thread overview]
Message-ID: <53165C2A.10403@linux.intel.com> (raw)
In-Reply-To: <1393965644-17393-1-git-send-email-abelous@broadcom.com>
On 03/04/2014 12:40 PM, Andrey Belous wrote:
> Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value
The format of your commit message is backwards, you need to have a short
message with the filename:
tclibc-uclibc: <short message>
<long message>
Signed-off-by: ....
Also this kind of change is distro specific and could be in your distro
specific information, don;'t you need to override more of what's in here
if you are using a prebuilt library?
Sau!
> ---
> meta/conf/distro/include/tclibc-uclibc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/distro/include/tclibc-uclibc.inc b/meta/conf/distro/include/tclibc-uclibc.inc
> index 9245112..a4d8c39 100644
> --- a/meta/conf/distro/include/tclibc-uclibc.inc
> +++ b/meta/conf/distro/include/tclibc-uclibc.inc
> @@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc"
> LIBCOVERRIDE = ":libc-uclibc"
> OVERRIDES .= "${LIBCOVERRIDE}"
>
> -PREFERRED_PROVIDER_virtual/libc = "uclibc"
> +PREFERRED_PROVIDER_virtual/libc ?= "uclibc"
> PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv"
> PREFERRED_PROVIDER_virtual/libintl ?= "gettext"
> PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc"
>
next prev parent reply other threads:[~2014-03-04 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 20:40 [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> Andrey Belous
2014-03-04 21:43 ` Phil Blundell
2014-03-04 21:55 ` Andrey Belous
2014-03-06 22:43 ` Khem Raj
2014-03-07 10:33 ` Nicolas Dechesne
2014-03-07 18:40 ` Khem Raj
2014-03-07 18:26 ` Phil Blundell
2014-03-04 23:05 ` Saul Wold [this message]
2014-03-04 23:11 ` Andrey Belous
2014-03-06 17:25 ` Nicolas Dechesne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53165C2A.10403@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=abelous@broadcom.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.