Re: [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build

[Julien Grall <julien.grall@linaro.org>]

On 05/03/14 09:02, Ian Campbell wrote:
> early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
>   xen/arch/arm/Rules.mk | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index aaa203e..aa2e79f 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -99,4 +99,12 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_INC=\"debug-$(EARLY_PRINTK_INC).inc\"
>   CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD)
>   CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS)
>   CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT)
> +
> +else # !debug
> +
> +ifneq ($(CONFIG_EARLY_PRINTK),)
> +# Early printk is dependant on a debug build.
> +$(error CONFIG_EARLY_PRINTK enabled for non-debug build)
> +endif
> +
>   endif
>

-- 
Julien Grall