All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER
Date: Wed, 05 Mar 2014 08:12:55 +0100	[thread overview]
Message-ID: <5316CE77.2030705@mind.be> (raw)
In-Reply-To: <1393887305-2252-1-git-send-email-yann.morin.1998@free.fr>

On 03/03/14 23:55, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> The user-facing variables should be prefixed with BR2_, not BR_.
> 
> Also quote the variable in the manual.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> ---
>  docs/manual/customize-toolchain.txt                  | 2 +-
>  toolchain/toolchain-external/ext-toolchain-wrapper.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/manual/customize-toolchain.txt b/docs/manual/customize-toolchain.txt
> index 4f3fe23..55a0480 100644
> --- a/docs/manual/customize-toolchain.txt
> +++ b/docs/manual/customize-toolchain.txt
> @@ -21,7 +21,7 @@ When using an external toolchain, Buildroot generates a wrapper program,
>  that transparently passes the appropriate options (according to the
>  configuration) to the external toolchain programs. In case you need to
>  debug this wrapper to check exactly what arguments are passed, you can
> -set the environment variable BR_DEBUG_WRAPPER to either one of:
> +set the environment variable +BR2_DEBUG_WRAPPER+ to either one of:
>  
>  * +0+, empty or not set: no debug
>  
> diff --git a/toolchain/toolchain-external/ext-toolchain-wrapper.c b/toolchain/toolchain-external/ext-toolchain-wrapper.c
> index 81c6ed1..db49784 100644
> --- a/toolchain/toolchain-external/ext-toolchain-wrapper.c
> +++ b/toolchain/toolchain-external/ext-toolchain-wrapper.c
> @@ -191,7 +191,7 @@ int main(int argc, char **argv)
>  	 * set to 1          : trace all arguments on a single line
>  	 * set to 2          : trace one argument per line
>  	 */
> -	if ((env_debug = getenv("BR_DEBUG_WRAPPER"))) {
> +	if ((env_debug = getenv("BR2_DEBUG_WRAPPER"))) {
>  		debug = atoi(env_debug);
>  		if (debug > 0) {
>  			fprintf(stderr, "Toolchain wrapper executing:");
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-03-05  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 22:55 [Buildroot] [PATCH] toolchain/wrapper: rename BR_DEBUG_WRAPPER Yann E. MORIN
2014-03-05  7:12 ` Arnout Vandecappelle [this message]
2014-03-05 18:46 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5316CE77.2030705@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.